Commit 030b6c0
committed
fix(realtime): reset stable-flag React state on options change; de-vacuous blip test
Address Greptile review:
- useStableFlag: reset React state to the fresh controller's baseline when
the controller is recreated on an options change, so a dynamic consumer
changing delayMs/minVisibleMs while active with value already false can no
longer strand the flag at true.
- test: read the live probe.active getter in the blip test instead of a
destructured snapshot, which was bound to false at destructure time and
made the assertion vacuous.1 parent 978bac1 commit 030b6c0
2 files changed
Lines changed: 11 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | | - | |
| 48 | + | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
109 | 115 | | |
110 | 116 | | |
111 | 117 | | |
| |||
0 commit comments