fix(api): wait for knowledge dispatch and encode filenames

Author: TheodoreSpeaks

apps/sim/app/api/v2/files/[fileId]/route.test.ts

@@ -141,6 +141,25 @@ describe('v2 single-file routes', () => {
     })
   })
 
+  it('encodes special characters in the extended download filename', async () => {
+    mocks.download.mockResolvedValueOnce({
+      file: fileRecord({ name: "it's (final)* café.pdf" }),
+      stream: new Blob(['pdf']).stream(),
+      contentType: 'application/pdf',
+      contentLength: 3,
+    })
+
+    const response = await GET(
+      new NextRequest(`http://localhost:3000/api/v2/files/${FILE_ID}?workspaceId=${WORKSPACE_ID}`),
+      context
+    )
+
+    expect(response.status).toBe(200)
+    expect(response.headers.get('Content-Disposition')).toBe(
+      `attachment; filename="it's (final)* caf_.pdf"; filename*=UTF-8''it%27s%20%28final%29%2A%20caf%C3%A9.pdf`
+    )
+  })
+
   it('conceals cross-workspace download authorization', async () => {
     mocks.download.mockRejectedValue(new NoWorkspaceAccessError())
 

apps/sim/app/api/v2/files/[fileId]/route.ts

@@ -14,6 +14,7 @@ import { deleteWorkspaceFileOperation } from '@/lib/workspace-files/application/
 import { downloadWorkspaceFileStream } from '@/lib/workspace-files/application/download-workspace-file'
 import { fileOperations } from '@/lib/workspace-files/application/operations'
 import { renameWorkspaceFile } from '@/lib/workspace-files/application/rename-workspace-file'
+import { encodeFilenameForHeader } from '@/app/api/files/utils'
 import { toV2File } from '@/app/api/v2/files/utils'
 
 export const dynamic = 'force-dynamic'
@@ -42,7 +43,7 @@ export const GET = defineV2BinaryRoute({
   present: ({ file, stream, contentType, contentLength }) => ({
     body: stream,
     contentType,
-    contentDisposition: `attachment; filename="${file.name.replace(/[^\w.-]/g, '_')}"; filename*=UTF-8''${encodeURIComponent(file.name)}`,
+    contentDisposition: `attachment; ${encodeFilenameForHeader(file.name)}`,
     contentLength,
   }),
 })

apps/sim/lib/knowledge/application/documents.test.ts

@@ -449,6 +449,26 @@ describe('knowledge document application use cases', () => {
     expect(mocks.recordAudit).not.toHaveBeenCalled()
   })
 
+  it('propagates processing dispatch failures without reporting upload success', async () => {
+    const failure = new Error('queue unavailable')
+    mocks.processQueue.mockRejectedValueOnce(failure)
+
+    await expect(
+      uploadKnowledgeDocument.execute({
+        principal: { kind: 'session', userId: 'user-1', sessionId: 'session-1' },
+        input: {
+          knowledgeBaseId: 'knowledge-1',
+          assertedWorkspaceId: 'workspace-1',
+          document,
+        },
+      })
+    ).rejects.toBe(failure)
+
+    expect(mocks.createDocument).toHaveBeenCalledOnce()
+    expect(mocks.processQueue).toHaveBeenCalledOnce()
+    expect(mocks.recordAudit).not.toHaveBeenCalled()
+  })
+
   it('bounds bulk document creation before billing or orchestration', async () => {
     await expect(
       createKnowledgeDocuments.execute({

apps/sim/lib/knowledge/application/documents.ts

@@ -287,19 +287,13 @@ export const uploadKnowledgeDocument = defineAuthorizedKnowledgeUseCase({
         fileSize: document.fileSize,
         mimeType: document.mimeType,
       }
-      processDocumentsWithQueue(
+      await processDocumentsWithQueue(
         [processingDocument],
         context.knowledgeBaseId,
         input.processingOptions ?? {},
         requestId,
         billingAttribution
-      ).catch((error: unknown) => {
-        logger.error('Knowledge document processing pipeline failed', {
-          knowledgeBaseId: context.knowledgeBaseId,
-          documentId: document.id,
-          error,
-        })
-      })
+      )
     }
     return { document, created: true as const }
   },