fix(icypeas): skip polling on BAD_INPUT and only treat validationErrors as a verdict

Author: TheodoreSpeaks

apps/sim/tools/icypeas-hosting.test.ts

@@ -147,6 +147,71 @@ describe('Icypeas transformResponse validation errors', () => {
       } as any)
     ).rejects.toThrow(/item _id/)
   })
+
+  it('verify-email throws on a bare success:false body without validationErrors', async () => {
+    const response = new Response(JSON.stringify({ success: false }), {
+      status: 200,
+      headers: { 'Content-Type': 'application/json' },
+    })
+
+    await expect(
+      icypeasVerifyEmailTool.transformResponse!(response, {
+        apiKey: 'test-key',
+        email: 'jane@example.com',
+      } as any)
+    ).rejects.toThrow(/item _id/)
+  })
+})
+
+describe('Icypeas postProcess on BAD_INPUT', () => {
+  it('verify-email returns the BAD_INPUT verdict without polling or throwing', async () => {
+    const fetchMock = vi.fn()
+    vi.stubGlobal('fetch', fetchMock)
+
+    const result = await icypeasVerifyEmailTool.postProcess!(
+      {
+        success: true as const,
+        output: {
+          searchId: null,
+          status: 'BAD_INPUT',
+          email: 'support@stripe.com',
+          valid: false,
+          item: {},
+        },
+      } as any,
+      { apiKey: 'test-key', email: 'support@stripe.com' } as any,
+      vi.fn()
+    )
+
+    expect(fetchMock).not.toHaveBeenCalled()
+    expect(result.success).toBe(true)
+    expect((result.output as any).status).toBe('BAD_INPUT')
+  })
+
+  it('find-email returns the BAD_INPUT verdict without polling or throwing', async () => {
+    const fetchMock = vi.fn()
+    vi.stubGlobal('fetch', fetchMock)
+
+    const result = await icypeasFindEmailTool.postProcess!(
+      {
+        success: true as const,
+        output: {
+          searchId: null,
+          status: 'BAD_INPUT',
+          email: null,
+          firstname: null,
+          lastname: null,
+          item: {},
+        },
+      } as any,
+      { apiKey: 'test-key', domainOrCompany: 'stripe.com' } as any,
+      vi.fn()
+    )
+
+    expect(fetchMock).not.toHaveBeenCalled()
+    expect(result.success).toBe(true)
+    expect((result.output as any).status).toBe('BAD_INPUT')
+  })
 })
 
 describe('Icypeas find-email postProcess poll', () => {

apps/sim/tools/icypeas/find_email.ts

@@ -116,8 +116,10 @@ export const icypeasFindEmailTool: ToolConfig<IcypeasFindEmailParams, IcypeasFin
     // it rejects the input up front (missing/invalid name or domain). There is no item
     // to poll — this is a BAD_INPUT verdict, not a transport error. Surface it as a
     // successful run with a null email so the enrichment cascade records the verdict
-    // instead of inflating the runner's error count.
-    if (json.success === false || Array.isArray(json.validationErrors)) {
+    // instead of inflating the runner's error count. Key on a non-empty validationErrors
+    // array specifically: a bare { success: false } is an unexpected failure shape that
+    // should fall through and throw, not be masked as BAD_INPUT.
+    if (Array.isArray(json.validationErrors) && json.validationErrors.length > 0) {
       return {
         success: true,
         output: {
@@ -145,16 +147,17 @@ export const icypeasFindEmailTool: ToolConfig<IcypeasFindEmailParams, IcypeasFin
   postProcess: async (result, params) => {
     if (!result.success) return result
 
+    // If already terminal, return immediately — a BAD_INPUT verdict has no searchId
+    // to poll, so this must run before the searchId guard.
+    if (result.output.status && TERMINAL_STATUSES.has(result.output.status)) {
+      return result
+    }
+
     const searchId = result.output.searchId
     if (!searchId) {
       throw new Error('Icypeas find-email result is missing a searchId')
     }
 
-    // If already terminal (unlikely on submit but defensive), return immediately.
-    if (result.output.status && TERMINAL_STATUSES.has(result.output.status)) {
-      return result
-    }
-
     let elapsed = 0
     while (elapsed < MAX_POLL_TIME_MS) {
       await sleep(POLL_INTERVAL_MS)

apps/sim/tools/icypeas/verify_email.ts

@@ -109,8 +109,10 @@ export const icypeasVerifyEmailTool: ToolConfig<
     // it rejects the input up front (bad format, role-based address, etc.). There is
     // no item to poll — this is a BAD_INPUT verdict, not a transport error. Surface it
     // as a successful run with valid=false so the enrichment cascade records the
-    // verdict instead of inflating the runner's error count.
-    if (json.success === false || Array.isArray(json.validationErrors)) {
+    // verdict instead of inflating the runner's error count. Key on a non-empty
+    // validationErrors array specifically: a bare { success: false } is an unexpected
+    // failure shape that should fall through and throw, not be masked as BAD_INPUT.
+    if (Array.isArray(json.validationErrors) && json.validationErrors.length > 0) {
       return {
         success: true,
         output: {
@@ -137,16 +139,17 @@ export const icypeasVerifyEmailTool: ToolConfig<
   postProcess: async (result, params) => {
     if (!result.success) return result
 
+    // If already terminal, return immediately — a BAD_INPUT verdict has no searchId
+    // to poll, so this must run before the searchId guard.
+    if (result.output.status && TERMINAL_STATUSES.has(result.output.status)) {
+      return result
+    }
+
     const searchId = result.output.searchId
     if (!searchId) {
       throw new Error('Icypeas verify-email result is missing a searchId')
     }
 
-    // If already terminal, return immediately.
-    if (result.output.status && TERMINAL_STATUSES.has(result.output.status)) {
-      return result
-    }
-
     let elapsed = 0
     while (elapsed < MAX_POLL_TIME_MS) {
       await sleep(POLL_INTERVAL_MS)