perf(icons): enforce three-decimal paths

Author: j15z

.github/workflows/test-build.yml

@@ -123,16 +123,6 @@ jobs:
       - name: Repo audits
         run: bun run check:audits
 
-      - name: Check SVG icon path precision
-        run: |
-          if [ "${{ github.event_name }}" = "pull_request" ]; then
-            BASE_REF="origin/${{ github.base_ref }}"
-            git fetch --depth=1 origin "${{ github.base_ref }}" 2>/dev/null || true
-          else
-            BASE_REF="HEAD~1"
-          fi
-          bun run check:icon-path-precision "$BASE_REF"
-
       - name: Migration safety (zero-downtime) audit
         run: |
           if [ "${{ github.event_name }}" = "pull_request" ]; then

apps/docs/components/icons.tsx

@@ -16,7 +16,7 @@ export function DocumentAttachment(props: SVGProps<SVGSVGElement>) {
       {...props}
     >
       <path
-        d='M10.5 5.69V5.1C10.5 3.99 10.499 3.2 10.414 2.61C10.33 2.02 10.18 1.69 9.91 1.44C9.65 1.19 9.28 1.04 8.65 0.96C8.01 0.88 7.17 0.875 6 0.875H5.38C4.2 0.875 3.36 0.88 2.72 0.96C2.09 1.04 1.73 1.19 1.46 1.44C1.2 1.69 1.04 2.02 0.96 2.61C0.88 3.2 0.88 3.99 0.88 5.1V7.44C0.88 8.55 0.88 9.34 0.96 9.94C1.04 10.52 1.2 10.85 1.46 11.1C1.73 11.354 2.09 11.5 2.72 11.58C3.36 11.67 4.2 11.67 5.38 11.67H5.69C5.93 11.67 6.125 11.86 6.125 12.1C6.125 12.35 5.93 12.54 5.69 12.54H5.38C4.23 12.54 3.32 12.54 2.61 12.45C1.9 12.36 1.32 12.17 0.86 11.739C0.4 11.3 0.19 10.75 0.09 10.06C0 9.39 8.49e-07 8.52 8.99e-07 7.44V5.1C9.49e-07 4.02 0 3.16 0.09 2.48C0.19 1.79 0.4 1.24 0.86 0.8C1.32 0.37 1.9 0.18 2.61 0.09C3.32 0 4.23 2.75e-07 5.38 3.23e-07H6C7.15 3.71e-07 8.06 0 8.76 0.09C9.48 0.18 10.06 0.37 10.51 0.8C10.98 1.24 11.18 1.79 11.28 2.48C11.38 3.16 11.375 4.02 11.375 5.1V5.69C11.375 5.93 11.18 6.125 10.94 6.125C10.7 6.125 10.5 5.93 10.5 5.69Z'
+        d='M10.5 5.69V5.1C10.5 3.99 10.499 3.2 10.414 2.61C10.33 2.02 10.18 1.69 9.91 1.44C9.65 1.19 9.28 1.04 8.65 0.96C8.01 0.88 7.17 0.875 6 0.875H5.38C4.2 0.875 3.36 0.88 2.72 0.96C2.09 1.04 1.73 1.19 1.46 1.44C1.2 1.69 1.04 2.02 0.96 2.61C0.88 3.2 0.88 3.99 0.88 5.1V7.44C0.88 8.55 0.88 9.34 0.96 9.94C1.04 10.52 1.2 10.85 1.46 11.1C1.73 11.354 2.09 11.5 2.72 11.58C3.36 11.67 4.2 11.67 5.38 11.67H5.69C5.93 11.67 6.125 11.86 6.125 12.1C6.125 12.35 5.93 12.54 5.69 12.54H5.38C4.23 12.54 3.32 12.54 2.61 12.45C1.9 12.36 1.32 12.17 0.86 11.739C0.4 11.3 0.19 10.75 0.09 10.06C0 9.39 0 8.52 0 7.44V5.1C0 4.02 0 3.16 0.09 2.48C0.19 1.79 0.4 1.24 0.86 0.8C1.32 0.37 1.9 0.18 2.61 0.09C3.32 0 4.23 0 5.38 0H6C7.15 0 8.06 0 8.76 0.09C9.48 0.18 10.06 0.37 10.51 0.8C10.98 1.24 11.18 1.79 11.28 2.48C11.38 3.16 11.375 4.02 11.375 5.1V5.69C11.375 5.93 11.18 6.125 10.94 6.125C10.7 6.125 10.5 5.93 10.5 5.69Z'
         fill='currentColor'
       />
       <path

apps/sim/components/icons.tsx

@@ -2,21 +2,20 @@ import { describe, expect, it } from 'vitest'
 import {
   analyzeIconSource,
   effectiveFractionDigits,
-  findNewPrecisionCandidates,
   findPrecisionCandidates,
 } from './check-icon-path-precision'
 
 const FIXTURE_PATH = '/repo/packages/emcn/src/icons/fixture.tsx'
 
 describe('icon path precision audit', () => {
-  it('accepts the two-decimal boundary and ignores geometry outside literal paths', () => {
+  it('accepts the three-decimal boundary and ignores geometry outside literal paths', () => {
     const source = `
       const dynamicPath = 'M0.1234 1'
       const unrelated = "d='M0.1234 1'"
       export function SafeIcon() {
         return (
           <svg viewBox='0 0 10.1234 10' transform='scale(0.16624)'>
-            <path d='M.5 1.20L1.2e1 2' />
+            <path d='M.5 1.200L1.2e1 2' />
             <path d={dynamicPath} />
           </svg>
         )
@@ -29,19 +28,19 @@ describe('icon path precision audit', () => {
     })
   })
 
-  it('finds ordinary decimals and exponents finer than a hundredth', () => {
+  it('finds ordinary decimals and exponents finer than a thousandth', () => {
     const source = `
       export function PreciseIcon() {
-        return <svg><path d='M0.123 1e-3L2.34 5' /></svg>
+        return <svg><path d='M0.1234 1e-4L2.345 5' /></svg>
       }
     `
 
     const candidates = findPrecisionCandidates(source, FIXTURE_PATH)
     expect(candidates).toHaveLength(1)
     expect(candidates[0]).toMatchObject({
       icon: 'PreciseIcon',
-      maxFractionDigits: 3,
-      offendingNumbers: ['0.123', '1e-3'],
+      maxFractionDigits: 4,
+      offendingNumbers: ['0.1234', '1e-4'],
     })
     expect(effectiveFractionDigits('2.13949e-05')).toBe(10)
   })
@@ -51,8 +50,8 @@ describe('icon path precision audit', () => {
       export function ExpressionIcon() {
         return (
           <svg>
-            <path d={'M0.123 1'} />
-            <path d={\`M2.345 3\`} />
+            <path d={'M0.1234 1'} />
+            <path d={\`M2.3456 3\`} />
           </svg>
         )
       }
@@ -84,7 +83,7 @@ describe('icon path precision audit', () => {
   it('rejects exceptions without a reason and exceptions on already-clean paths', () => {
     const missingReason = `
       export function PreciseIcon() {
-        return <svg>{/** svg-path-precision-exception: */}<path d='M0.123 1' /></svg>
+        return <svg>{/** svg-path-precision-exception: */}<path d='M0.1234 1' /></svg>
       }
     `
     const unnecessary = `
@@ -102,31 +101,7 @@ describe('icon path precision audit', () => {
     expect(unnecessaryAnalysis.invalidExceptions[0]?.message).toContain('unnecessary')
   })
 
-  it('grandfathers exact paths from the target branch but rejects additions and edits', () => {
-    const base = `
-      export function LegacyIcon() {
-        return <svg><path d='M0.123 1' /></svg>
-      }
-    `
-    const unchanged = findPrecisionCandidates(base, FIXTURE_PATH)
-    expect(findNewPrecisionCandidates(unchanged, unchanged)).toEqual([])
-
-    const duplicate = `
-      export function LegacyIcon() {
-        return <svg><path d='M0.123 1' /><path d='M0.123 1' /></svg>
-      }
-    `
-    expect(
-      findNewPrecisionCandidates(findPrecisionCandidates(duplicate, FIXTURE_PATH), unchanged)
-    ).toHaveLength(1)
-
-    const changed = base.replace('0.123', '0.1234')
-    expect(
-      findNewPrecisionCandidates(findPrecisionCandidates(changed, FIXTURE_PATH), unchanged)
-    ).toHaveLength(1)
-  })
-
-  it('requires a committed exception to remain while its precise path remains', () => {
+  it('requires a reasoned exception to remain while its precise path remains', () => {
     const excepted = `
       export function PreciseBrandIcon() {
         return (
@@ -143,8 +118,6 @@ describe('icon path precision audit', () => {
     )
 
     expect(findPrecisionCandidates(excepted, FIXTURE_PATH)).toEqual([])
-    expect(
-      findNewPrecisionCandidates(findPrecisionCandidates(exceptionRemoved, FIXTURE_PATH), [])
-    ).toHaveLength(1)
+    expect(findPrecisionCandidates(exceptionRemoved, FIXTURE_PATH)).toHaveLength(1)
   })
 })

packages/emcn/src/icons/document-attachment.tsx

@@ -1,21 +1,18 @@
 #!/usr/bin/env bun
 /**
- * Prevents newly introduced overly precise numeric values in literal SVG icon
- * `d` attributes.
+ * Prevents overly precise numeric values in literal SVG icon `d` attributes.
  *
- * Two decimal places are enough for the reusable icons covered here: additional
- * digits increase shipped source without a visible benefit. Paths already in the
- * target branch are grandfathered by exact content, while new paths and edits to
- * old paths must satisfy the limit or carry a reasoned local exception.
+ * Three decimal places are enough for the reusable icons covered here: additional
+ * digits increase shipped source without a visible benefit. Every path must
+ * satisfy the limit or carry a reasoned local exception.
  *
  * Scope is intentionally limited to the shared app/docs icon catalogs and EMCN
  * icon components. SVG transforms, view boxes, dynamic path expressions, and
  * page-specific artwork are not inspected because their safe precision depends
  * on context.
  *
- * Run against the intended merge target: `bun run check:icon-path-precision staging`
+ * Run with `bun run check:icon-path-precision`.
  */
-import { createHash } from 'node:crypto'
 import { readdir, readFile } from 'node:fs/promises'
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
@@ -27,11 +24,10 @@ const STATIC_ICON_FILES = [
   path.join(ROOT, 'apps/docs/components/icons.tsx'),
   path.join(ROOT, 'apps/sim/components/icons.tsx'),
 ]
-const STATIC_ICON_PATHS = STATIC_ICON_FILES.map((file) => normalizedRelativePath(file))
 const SVG_NUMBER_PATTERN = /[+-]?(?:(?:\d+\.\d*)|(?:\.\d+)|(?:\d+))(?:[eE][+-]?\d+)?/g
 const PRECISION_EXCEPTION_DIRECTIVE = 'svg-path-precision-exception:'
 
-export const MAX_ICON_PATH_FRACTION_DIGITS = 2
+export const MAX_ICON_PATH_FRACTION_DIGITS = 3
 
 interface ParsedPrecisionException {
   line: number
@@ -49,7 +45,6 @@ export interface PrecisionCandidate {
   file: string
   icon: string
   line: number
-  pathHash: string
   maxFractionDigits: number
   offendingNumbers: string[]
 }
@@ -261,10 +256,6 @@ export function effectiveFractionDigits(numberLiteral: string): number {
   return Math.max(writtenFractionDigits, exponentFractionDigits)
 }
 
-function hashPath(pathValue: string): string {
-  return createHash('sha256').update(pathValue).digest('hex')
-}
-
 function normalizedRelativePath(file: string): string {
   return path.relative(ROOT, file).split(path.sep).join('/')
 }
@@ -296,7 +287,7 @@ export function analyzeIconSource(source: string, file: string): IconPrecisionAn
         invalidExceptions.push({
           file: normalizedFile,
           line: literalPath.exception.line,
-          message: 'Exception is unnecessary because this path uses at most two decimal places.',
+          message: 'Exception is unnecessary because this path uses at most three decimal places.',
         })
       } else {
         continue
@@ -308,7 +299,6 @@ export function analyzeIconSource(source: string, file: string): IconPrecisionAn
       file: normalizedFile,
       icon: literalPath.icon,
       line: literalPath.line,
-      pathHash: hashPath(literalPath.value),
       maxFractionDigits: Math.max(...preciseNumbers.map(effectiveFractionDigits)),
       offendingNumbers: [...new Set(preciseNumbers)].slice(0, 4),
     })
@@ -321,23 +311,6 @@ export function findPrecisionCandidates(source: string, file: string): Precision
   return analyzeIconSource(source, file).candidates
 }
 
-export function findNewPrecisionCandidates(
-  current: PrecisionCandidate[],
-  base: PrecisionCandidate[]
-): PrecisionCandidate[] {
-  const allowedCounts = new Map<string, number>()
-  for (const candidate of base) {
-    allowedCounts.set(candidate.pathHash, (allowedCounts.get(candidate.pathHash) ?? 0) + 1)
-  }
-
-  const seenCounts = new Map<string, number>()
-  return current.filter((candidate) => {
-    const seen = (seenCounts.get(candidate.pathHash) ?? 0) + 1
-    seenCounts.set(candidate.pathHash, seen)
-    return seen > (allowedCounts.get(candidate.pathHash) ?? 0)
-  })
-}
-
 async function currentIconFiles(): Promise<string[]> {
   const emcnIcons = (await readdir(EMCN_ICONS_DIRECTORY))
     .filter((file) => file.endsWith('.tsx'))
@@ -346,37 +319,6 @@ async function currentIconFiles(): Promise<string[]> {
   return [...STATIC_ICON_FILES, ...emcnIcons]
 }
 
-function gitOutput(arguments_: string[]): string {
-  const result = Bun.spawnSync(['git', ...arguments_], {
-    cwd: ROOT,
-    stdout: 'pipe',
-    stderr: 'pipe',
-  })
-  if (result.exitCode !== 0) {
-    const error = new TextDecoder().decode(result.stderr).trim()
-    throw new Error(`git ${arguments_.join(' ')} failed: ${error}`)
-  }
-  return new TextDecoder().decode(result.stdout)
-}
-
-function baseIconPaths(baseCommit: string): string[] {
-  const output = gitOutput([
-    'ls-tree',
-    '-r',
-    '--name-only',
-    baseCommit,
-    '--',
-    ...STATIC_ICON_PATHS,
-    'packages/emcn/src/icons',
-  ])
-  return output
-    .split('\n')
-    .filter(
-      (file) =>
-        STATIC_ICON_PATHS.includes(file) || /^packages\/emcn\/src\/icons\/.*\.tsx$/.test(file)
-    )
-}
-
 async function scanCurrentFiles(files: string[]): Promise<IconPrecisionAnalysis> {
   const candidates: PrecisionCandidate[] = []
   const invalidExceptions: InvalidPrecisionException[] = []
@@ -388,15 +330,6 @@ async function scanCurrentFiles(files: string[]): Promise<IconPrecisionAnalysis>
   return { candidates, invalidExceptions }
 }
 
-function scanBaseFiles(baseCommit: string, files: string[]): PrecisionCandidate[] {
-  const candidates: PrecisionCandidate[] = []
-  for (const file of files) {
-    const source = gitOutput(['show', `${baseCommit}:${file}`])
-    candidates.push(...findPrecisionCandidates(source, path.join(ROOT, file)))
-  }
-  return candidates
-}
-
 function printCandidate(candidate: PrecisionCandidate): void {
   console.error(
     `  ${candidate.file}:${candidate.line} (${candidate.icon}) — ${candidate.maxFractionDigits} fractional digits`
@@ -405,18 +338,13 @@ function printCandidate(candidate: PrecisionCandidate): void {
 }
 
 async function main(): Promise<void> {
-  const [baseRef, ...unknownArguments] = process.argv.slice(2)
-  if (!baseRef || unknownArguments.length > 0 || baseRef.startsWith('-')) {
-    console.error('Usage: bun run check:icon-path-precision <base-ref>')
-    console.error('Example: bun run check:icon-path-precision staging')
+  if (process.argv.length > 2) {
+    console.error('Usage: bun run check:icon-path-precision')
     process.exit(1)
   }
 
-  const baseCommit = gitOutput(['rev-parse', '--verify', `${baseRef}^{commit}`]).trim()
   const files = await currentIconFiles()
   const current = await scanCurrentFiles(files)
-  const baseCandidates = scanBaseFiles(baseCommit, baseIconPaths(baseCommit))
-  const newCandidates = findNewPrecisionCandidates(current.candidates, baseCandidates)
 
   if (current.invalidExceptions.length > 0) {
     console.error(
@@ -427,13 +355,13 @@ async function main(): Promise<void> {
     }
   }
 
-  if (newCandidates.length > 0) {
+  if (current.candidates.length > 0) {
     console.error(
-      `\nFound ${newCandidates.length} new or changed icon path(s) with more than ${MAX_ICON_PATH_FRACTION_DIGITS} fractional digits compared with ${baseRef}:\n`
+      `\nFound ${current.candidates.length} icon path(s) with more than ${MAX_ICON_PATH_FRACTION_DIGITS} fractional digits:\n`
     )
-    for (const candidate of newCandidates) printCandidate(candidate)
+    for (const candidate of current.candidates) printCandidate(candidate)
     console.error(
-      '\nRound only numeric values inside the literal d attribute to at most two decimal places.'
+      '\nRound only numeric values inside the literal d attribute to at most three decimal places.'
     )
     console.error(
       'If extra precision is visibly necessary, place this reasoned exception immediately before that path:'
@@ -446,12 +374,12 @@ async function main(): Promise<void> {
     )
   }
 
-  if (current.invalidExceptions.length > 0 || newCandidates.length > 0) {
+  if (current.invalidExceptions.length > 0 || current.candidates.length > 0) {
     process.exit(1)
   }
 
   console.log(
-    `✓ No new overly precise icon paths compared with ${baseRef} (${files.length} current icon files checked).`
+    `✓ All literal icon paths use at most three decimal places (${files.length} files checked).`
   )
 }
 

scripts/check-icon-path-precision.test.ts

@@ -17,7 +17,6 @@ import path from 'node:path'
 const EXCLUDED: Record<string, string> = {
   'check:audits': 'this runner',
   'check:migrations': 'needs a git base ref argument',
-  'check:icon-path-precision': 'needs a git base ref argument',
   'check:api-validation': 'superseded by the :strict variant, which this runner does run',
 }