fix(enrichment): address review — persist detail on cancel/skip, exclude not_run from ran count, refetch on panel open

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/enrichment-details/enrichment-details.tsx

@@ -19,7 +19,7 @@ import { MAX_LOG_DETAILS_WIDTH_RATIO, MIN_LOG_DETAILS_WIDTH } from '@/stores/log
 
 type EnrichmentDetailsTab = 'result' | 'cascade'
 
-type ResultStatus = 'matched' | 'no_match' | 'error'
+type ResultStatus = 'matched' | 'no_match' | 'error' | 'not_run'
 
 const RESULT_STATUS_CONFIG: Record<
   ResultStatus,
@@ -28,6 +28,7 @@ const RESULT_STATUS_CONFIG: Record<
   matched: { variant: 'green', label: 'Matched' },
   no_match: { variant: 'gray', label: 'No match' },
   error: { variant: 'red', label: 'Error' },
+  not_run: { variant: 'gray', label: 'Not run' },
 }
 
 /** Minimum bar width so a sub-millisecond provider still shows on the timeline. */
@@ -69,15 +70,21 @@ function buildCascadeRows(providers: EnrichmentProviderOutcome[]): CascadeRow[]
   })
 }
 
+/** A provider that actually executed its tool (not skipped / never reached). */
+function didRun(p: EnrichmentProviderOutcome): boolean {
+  return p.status !== 'skipped' && p.status !== 'not_run'
+}
+
 /**
  * Derives the cell-level outcome from the cascade — mirrors the executor: a run
- * is `error` only when every provider that actually ran errored; a clean miss is
- * `no_match`.
+ * is `error` only when every provider that ran errored; `not_run` when nothing
+ * executed (missing inputs / cancelled early); otherwise a clean `no_match`.
  */
 function deriveResultStatus(detail: EnrichmentRunDetail): ResultStatus {
   if (detail.matchedProvider) return 'matched'
-  const ran = detail.providers.filter((p) => p.status !== 'skipped')
-  if (ran.length > 0 && ran.every((p) => p.status === 'error')) return 'error'
+  const ran = detail.providers.filter(didRun)
+  if (ran.length === 0) return 'not_run'
+  if (ran.every((p) => p.status === 'error')) return 'error'
   return 'no_match'
 }
 
@@ -131,7 +138,7 @@ function EnrichmentDetailsContent({
     ? (detail.providers.find((p) => p.id === detail.matchedProvider)?.label ??
       detail.matchedProvider)
     : null
-  const ranCount = detail ? detail.providers.filter((p) => p.status !== 'skipped').length : 0
+  const ranCount = detail ? detail.providers.filter(didRun).length : 0
   const lastError = detail
     ? [...detail.providers].reverse().find((p) => p.status === 'error')?.error
     : null
@@ -229,7 +236,7 @@ function EnrichmentDetailsContent({
           {/* Provider waterfall — each row is one cascade attempt on a shared timeline */}
           <div className='flex flex-col pb-4'>
             {buildCascadeRows(detail.providers).map(({ outcome, offsetPct, widthPct }) => {
-              const ran = outcome.status !== 'skipped' && outcome.status !== 'not_run'
+              const ran = didRun(outcome)
               const { icon: ProviderIcon, bgColor: rawBgColor } = getBlockIconAndColor(
                 'tool',
                 outcome.toolId

apps/sim/background/workflow-column-execution.ts

@@ -208,7 +208,7 @@ async function runWorkflowAndWriteTerminal(
     // workflow path rather than erroring.
     if (group.type === 'enrichment' && group.enrichmentId) {
       const { getEnrichment } = await import('@/enrichments/registry')
-      const { runEnrichment } = await import('@/enrichments/run')
+      const { runEnrichment, skippedEnrichmentDetail } = await import('@/enrichments/run')
       const enrichment = getEnrichment(group.enrichmentId)
       // `tableRowExecutions.workflowId` is an opaque id for status; use the
       // enrichment id for enrichment cells.
@@ -320,6 +320,7 @@ async function runWorkflowAndWriteTerminal(
             jobId: null,
             workflowId: statusId,
             error: null,
+            enrichmentDetails: skippedEnrichmentDetail(enrichment),
           },
           clearPatch
         )
@@ -334,6 +335,7 @@ async function runWorkflowAndWriteTerminal(
             jobId: null,
             workflowId: statusId,
             error: 'Cancelled',
+            enrichmentDetails: skippedEnrichmentDetail(enrichment),
           })
           return 'error'
         }
@@ -352,6 +354,7 @@ async function runWorkflowAndWriteTerminal(
             jobId: null,
             workflowId: statusId,
             error: 'Cancelled',
+            enrichmentDetails: detail,
           })
           return 'error'
         }

apps/sim/enrichments/run.test.ts

@@ -6,7 +6,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
 const { mockExecuteTool } = vi.hoisted(() => ({ mockExecuteTool: vi.fn() }))
 vi.mock('@/tools', () => ({ executeTool: mockExecuteTool }))
 
-import { runEnrichment } from '@/enrichments/run'
+import { runEnrichment, skippedEnrichmentDetail } from '@/enrichments/run'
 import type { EnrichmentConfig, EnrichmentProvider } from '@/enrichments/types'
 
 const ICON = (() => null) as unknown as EnrichmentConfig['icon']
@@ -117,6 +117,14 @@ describe('runEnrichment cascade detail', () => {
     expect(outcome.detail.providers.map((p) => p.status)).toEqual(['no_match'])
   })
 
+  it('skippedEnrichmentDetail marks every provider skipped without running', () => {
+    const detail = skippedEnrichmentDetail(config([prov('a'), prov('b')]))
+    expect(detail.matchedProvider).toBeNull()
+    expect(detail.totalCost).toBe(0)
+    expect(detail.providers.map((p) => p.status)).toEqual(['skipped', 'skipped'])
+    expect(mockExecuteTool).not.toHaveBeenCalled()
+  })
+
   it('does not error when some providers no-match and only some error', async () => {
     mockExecuteTool.mockImplementation((toolId: string) => {
       if (toolId === 'tool_a') return { success: false, output: { status: 500 } }

apps/sim/enrichments/run.ts

@@ -24,6 +24,32 @@ export interface EnrichmentRunOutcome {
   detail: EnrichmentRunDetail
 }
 
+/**
+ * Detail for a terminal cell that recorded no provider attempt — missing
+ * required inputs, or cancelled before any provider ran. Every provider is
+ * marked `skipped` so the details panel stays informative (shows the configured
+ * cascade) instead of empty.
+ */
+export function skippedEnrichmentDetail(enrichment: EnrichmentConfig): EnrichmentRunDetail {
+  const now = new Date().toISOString()
+  return {
+    startedAt: now,
+    completedAt: now,
+    durationMs: 0,
+    totalCost: 0,
+    matchedProvider: null,
+    providers: enrichment.providers.map((provider) => ({
+      id: provider.id,
+      label: provider.label,
+      toolId: provider.toolId,
+      status: 'skipped' as const,
+      cost: 0,
+      durationMs: 0,
+      error: null,
+    })),
+  }
+}
+
 /** True when at least one output value in the result is non-empty. */
 function hasResult(result: Record<string, unknown>): boolean {
   return Object.values(result).some((v) => v !== undefined && v !== null && v !== '')

apps/sim/hooks/queries/tables.ts

@@ -307,6 +307,11 @@ async function fetchEnrichmentDetail(
  * Enrichment cascade breakdown for one cell, fetched on demand when the
  * enrichment details panel opens. Kept off the hot grid read — only queried
  * while `enabled` (panel open with a selected row + group).
+ *
+ * `staleTime: 0` so reopening the panel always refetches: a cell can be re-run
+ * between opens (the run writes new `enrichmentDetails` in the background with no
+ * client invalidation), and the panel is opened on demand, so a fresh fetch per
+ * open keeps the cascade in sync without a cached stale run.
  */
 export function useEnrichmentDetail(
   tableId: string,
@@ -319,7 +324,7 @@ export function useEnrichmentDetail(
     queryFn: ({ signal }) =>
       fetchEnrichmentDetail(tableId, rowId as string, groupId as string, signal),
     enabled: Boolean(tableId && rowId && groupId) && (options?.enabled ?? true),
-    staleTime: 30 * 1000,
+    staleTime: 0,
   })
 }