error on partial upload failures

Author: icecrasher321

apps/sim/app/api/tools/sharepoint/upload/route.ts

@@ -10,10 +10,12 @@ import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
 import { processFilesToUserFiles } from '@/lib/uploads/utils/file-utils'
 import { downloadFileFromStorage } from '@/lib/uploads/utils/file-utils.server'
 import type { MicrosoftGraphDriveItem } from '@/tools/onedrive/types'
+import type { SharepointSkippedFile, SharepointUploadError } from '@/tools/sharepoint/types'
 
 export const dynamic = 'force-dynamic'
 
 const logger = createLogger('SharepointUploadAPI')
+const MAX_SHAREPOINT_UPLOAD_BYTES = 250 * 1024 * 1024
 
 export const POST = withRouteHandler(async (request: NextRequest) => {
   const requestId = generateRequestId()
@@ -76,6 +78,8 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
     const siteId = validatedData.siteId.trim() || 'root'
     const driveId = validatedData.driveId?.trim() || null
     const uploadedFiles: MicrosoftGraphDriveItem[] = []
+    const skippedFiles: SharepointSkippedFile[] = []
+    const errors: SharepointUploadError[] = []
 
     for (const userFile of userFiles) {
       logger.info(`[${requestId}] Uploading file: ${userFile.name}`)
@@ -87,10 +91,16 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
 
       const fileSizeMB = buffer.length / (1024 * 1024)
 
-      if (fileSizeMB > 250) {
+      if (buffer.length > MAX_SHAREPOINT_UPLOAD_BYTES) {
         logger.warn(
           `[${requestId}] File ${fileName} is ${fileSizeMB.toFixed(2)}MB, exceeds 250MB limit`
         )
+        skippedFiles.push({
+          name: fileName,
+          size: buffer.length,
+          limit: MAX_SHAREPOINT_UPLOAD_BYTES,
+          reason: 'File exceeds the 250 MB Microsoft Graph small upload limit',
+        })
         continue
       }
 
@@ -155,13 +165,12 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
               error?: { message?: string }
             }
             logger.error(`[${requestId}] Failed to replace file ${fileName}:`, replaceErrorData)
-            return NextResponse.json(
-              {
-                success: false,
-                error: replaceErrorData.error?.message || `Failed to replace file: ${fileName}`,
-              },
-              { status: replaceResponse.status }
-            )
+            errors.push({
+              name: fileName,
+              status: replaceResponse.status,
+              error: replaceErrorData.error?.message || `Failed to replace file: ${fileName}`,
+            })
+            continue
           }
 
           const replaceData = (await replaceResponse.json()) as {
@@ -185,15 +194,14 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
           continue
         }
 
-        return NextResponse.json(
-          {
-            success: false,
-            error:
-              (errorData as { error?: { message?: string } }).error?.message ||
-              `Failed to upload file: ${fileName}`,
-          },
-          { status: uploadResponse.status }
-        )
+        errors.push({
+          name: fileName,
+          status: uploadResponse.status,
+          error:
+            (errorData as { error?: { message?: string } }).error?.message ||
+            `Failed to upload file: ${fileName}`,
+        })
+        continue
       }
 
       const uploadData = (await uploadResponse.json()) as MicrosoftGraphDriveItem
@@ -210,22 +218,33 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
     }
 
     if (uploadedFiles.length === 0) {
-      return NextResponse.json(
-        {
-          success: false,
-          error: 'No files were uploaded successfully',
+      return NextResponse.json({
+        success: false,
+        error: 'No files were uploaded successfully',
+        output: {
+          uploadedFiles,
+          fileCount: 0,
+          skippedFiles,
+          skippedCount: skippedFiles.length,
+          errors,
         },
-        { status: 400 }
-      )
+      })
     }
 
-    logger.info(`[${requestId}] Successfully uploaded ${uploadedFiles.length} file(s)`)
+    logger.info(`[${requestId}] Completed SharePoint upload`, {
+      uploadedCount: uploadedFiles.length,
+      skippedCount: skippedFiles.length,
+      errorCount: errors.length,
+    })
 
     return NextResponse.json({
       success: true,
       output: {
         uploadedFiles,
         fileCount: uploadedFiles.length,
+        skippedFiles,
+        skippedCount: skippedFiles.length,
+        errors,
       },
     })
   } catch (error) {

apps/sim/blocks/blocks/sharepoint.ts

@@ -1033,6 +1033,15 @@ Return ONLY the JSON object - no explanations, no markdown, no extra text.`,
       description: 'Array of uploaded file objects with id, name, webUrl, size',
     },
     fileCount: { type: 'number', description: 'Number of files uploaded' },
+    skippedFiles: {
+      type: 'json',
+      description: 'Array of skipped upload files (name, size, limit, reason)',
+    },
+    skippedCount: { type: 'number', description: 'Number of files skipped' },
+    errors: {
+      type: 'json',
+      description: 'Array of per-file upload errors (name, error, status)',
+    },
     nextPageUrl: {
       type: 'string',
       description: 'Microsoft Graph @odata.nextLink URL for the next page of results',

apps/sim/tools/sharepoint/types.ts

@@ -285,9 +285,25 @@ export interface SharepointUploadedFile {
   lastModifiedDateTime?: string
 }
 
+export interface SharepointSkippedFile {
+  name: string
+  size: number
+  limit: number
+  reason: string
+}
+
+export interface SharepointUploadError {
+  name: string
+  error: string
+  status?: number
+}
+
 export interface SharepointUploadFileResponse extends ToolResponse {
   output: {
     uploadedFiles: SharepointUploadedFile[]
     fileCount: number
+    skippedFiles?: SharepointSkippedFile[]
+    skippedCount?: number
+    errors?: SharepointUploadError[]
   }
 }

apps/sim/tools/sharepoint/upload_file.ts

@@ -74,15 +74,17 @@ export const uploadFileTool: ToolConfig<SharepointToolParams, SharepointUploadFi
 
   transformResponse: async (response: Response) => {
     const data = await response.json()
-    if (!data.success) {
-      throw new Error(data.error || 'Failed to upload files to SharePoint')
-    }
+    const output = data.output ?? {}
     return {
-      success: true,
+      success: Boolean(data.success),
       output: {
-        uploadedFiles: data.output.uploadedFiles,
-        fileCount: data.output.fileCount,
+        uploadedFiles: output.uploadedFiles ?? [],
+        fileCount: output.fileCount ?? 0,
+        skippedFiles: output.skippedFiles ?? [],
+        skippedCount: output.skippedCount ?? 0,
+        errors: output.errors ?? [],
       },
+      error: data.success ? undefined : data.error || 'Failed to upload files to SharePoint',
     }
   },
 
@@ -106,5 +108,38 @@ export const uploadFileTool: ToolConfig<SharepointToolParams, SharepointUploadFi
       type: 'number',
       description: 'Number of files uploaded',
     },
+    skippedFiles: {
+      type: 'array',
+      description: 'Files that were skipped before upload',
+      items: {
+        type: 'object',
+        properties: {
+          name: { type: 'string', description: 'File name' },
+          size: { type: 'number', description: 'File size in bytes' },
+          limit: { type: 'number', description: 'Upload size limit in bytes' },
+          reason: { type: 'string', description: 'Reason the file was skipped' },
+        },
+      },
+    },
+    skippedCount: {
+      type: 'number',
+      description: 'Number of files skipped',
+    },
+    errors: {
+      type: 'array',
+      description: 'Per-file upload errors',
+      items: {
+        type: 'object',
+        properties: {
+          name: { type: 'string', description: 'File name' },
+          error: { type: 'string', description: 'Error message' },
+          status: {
+            type: 'number',
+            description: 'HTTP status from Microsoft Graph',
+            optional: true,
+          },
+        },
+      },
+    },
   },
 }