Merge branch 'midnight' into midnight

Author: SzynaWoW

.github/workflows/build.yml

@@ -53,7 +53,7 @@ jobs:
         env:
           CCACHE_BASEDIR: ${{ runner.workspace }}
           CCACHE_DIR: ${{ runner.workspace }}/.ccache
-          CCACHE_MAXSIZE: 192M # full build consumes around ~80, ~2x that to be safe
+          CCACHE_MAXSIZE: 256M # original size ~1.1G, assume ~5x compression
         run: |
           ccache -z
           ninja -C '${{ runner.workspace }}/b/ninja'
@@ -120,7 +120,7 @@ jobs:
         env:
           CCACHE_BASEDIR: ${{ runner.workspace }}
           CCACHE_DIR: ${{ runner.workspace }}/.ccache
-          CCACHE_MAXSIZE: 256M # full build consumes around ~124, ~2x that to be safe
+          CCACHE_MAXSIZE: 304M # original size ~1.5G, assume ~5x compression
         run: |
           ccache -z
           ninja -C '${{ runner.workspace }}/b/ninja'
@@ -142,46 +142,74 @@ jobs:
     steps:
       - uses: actions/checkout@v6
 
-      - name: Build
-        run: make SANITIZE=1 -C engine debug -j 2
+      - uses: actions/cache@v5
+        env:
+          CCACHE_PREFIX: "macos-cpp-ccache-${{ env.CCACHE_GENERATION }}"
+        with:
+          path: ${{ runner.workspace }}/.ccache
+          key: ${{ env.CCACHE_PREFIX }}-${{ github.sha }}
+          restore-keys: ${{ env.CCACHE_PREFIX }}-
 
-      - name: Smoke Test
-        if: inputs.do-test == 'true'
-        run: ./engine/simc $SIMC_PROFILE iterations=5 output=/dev/null html=/dev/null json2=/dev/null cleanup_threads=1
+      - name: Install deps
+        run: |
+          brew update
+          brew install ccache
+
+      - name: Build
+        env:
+          CCACHE_BASEDIR: ${{ runner.workspace }}
+          CCACHE_DIR: ${{ runner.workspace }}/.ccache
+          CCACHE_MAXSIZE: 416M # original size ~2.0G, assume ~5x compression
+        run: |
+          ccache -z
+          make CXX="ccache c++" SANITIZE=1 -C engine debug -j 2
+          ccache -s
 
   windows-VS:
-    name: windows-VS-${{ matrix.vs }}-${{ matrix.arch }}
+    name: windows-VS-${{ matrix.arch }}
     runs-on: windows-latest
     strategy:
       matrix:
-        vs: [2019]
         arch: [x64, amd64_arm64]
-        include:
-          - arch: x64
-            runSmokeTest: false # disable smoke test for now, as it seems to hang the workflow indefinitely on assert, instead of failing.
 
     env:
       CMAKE_BUILD_DIR: ${{ github.workspace }}/builddir/
 
     steps:
       - uses: actions/checkout@v6
 
-        # Setup the build machine with the most recent versions of CMake and Ninja. Both are cached if not already: on subsequent runs both will be quickly restored from GitHub cache service.
-      - uses: lukka/get-cmake@latest
+      - uses: actions/cache@v5
+        env:
+          CCACHE_PREFIX: "windows-${{ matrix.arch }}-cpp-ccache-${{ env.CCACHE_GENERATION }}"
+        with:
+          path: ${{ github.workspace }}\.ccache
+          key: ${{ env.CCACHE_PREFIX }}-${{ github.sha }}
+          restore-keys: ${{ env.CCACHE_PREFIX }}-
 
       # On Windows runners, let's ensure to have the Developer Command Prompt environment setup correctly. As used here the Developer Command Prompt created is targeting x64 and using the default the Windows SDK.
       - uses: ilammy/msvc-dev-cmd@v1
         with:
           arch: ${{ matrix.arch }}
 
+      - name: Install deps
+        run: |
+          choco install -y ccache
+
       - name: Generate project files
         run: |
-          cmake -B "${{ env.CMAKE_BUILD_DIR }}" -GNinja -DBUILD_GUI=OFF -DCMAKE_BUILD_TYPE=Debug
+          cmake -B "${{ env.CMAKE_BUILD_DIR }}" `
+            -GNinja `
+            -DBUILD_GUI=OFF `
+            -DCMAKE_BUILD_TYPE=Debug `
+            -DCMAKE_CXX_COMPILER_LAUNCHER=ccache `
+            -DCMAKE_CXX_FLAGS_DEBUG="/Z7"
 
       - name: Build
+        env:
+          CCACHE_BASEDIR: ${{ github.workspace }}
+          CCACHE_DIR: ${{ github.workspace }}\.ccache
+          CCACHE_MAXSIZE: 192M # original size ~1.1G, assume ~6x compression
         run: |
+          ccache -z
           cmake --build "${{ env.CMAKE_BUILD_DIR }}"
-
-      - name: Smoke Test
-        if: matrix.runSmokeTest && inputs.do-test == 'true'
-        run: ${{ env.CMAKE_BUILD_DIR }}/simc.exe $env:SIMC_PROFILE iterations=5 output=nul html=nul json2=nul cleanup_threads=1
+          ccache -s

.github/workflows/main.yml

@@ -26,6 +26,168 @@ jobs:
     with:
       do-test: ${{ github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch }}
 
+  spec-test-selection:
+    runs-on: ubuntu-22.04
+    if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
+    outputs:
+      spec-matrix: ${{ steps.select.outputs.spec-matrix }}
+    steps:
+      - uses: actions/checkout@v6
+        with:
+          fetch-depth: 2
+
+      - name: Select Specs From Changed Files
+        id: select
+        shell: bash
+        run: |
+          set -euo pipefail
+
+          ALL_SPECS=(
+            deathknight_blood
+            deathknight_unholy
+            deathknight_frost
+            demonhunter_devourer
+            demonhunter_havoc
+            demonhunter_vengeance
+            druid_balance
+            druid_feral
+            druid_guardian
+            druid_restoration
+            evoker_devastation
+            evoker_augmentation
+            hunter_beast_mastery
+            hunter_marksmanship
+            hunter_survival
+            mage_arcane
+            mage_fire
+            mage_frost
+            monk_brewmaster
+            monk_windwalker
+            paladin_protection
+            paladin_retribution
+            priest_shadow
+            rogue_assassination
+            rogue_outlaw
+            rogue_subtlety
+            shaman_elemental
+            shaman_enhancement
+            warlock_affliction
+            warlock_demonology
+            warlock_destruction
+            warrior_arms
+            warrior_fury
+            warrior_protection
+          )
+
+          if [[ "${GITHUB_EVENT_NAME}" == "pull_request" ]]; then
+            BASE_SHA="${{ github.event.pull_request.base.sha }}"
+            HEAD_SHA="${{ github.event.pull_request.head.sha }}"
+          else
+            BASE_SHA="${{ github.event.before }}"
+            HEAD_SHA="${{ github.sha }}"
+          fi
+
+          mapfile -t CHANGED_FILES < <(git diff --name-only "$BASE_SHA" "$HEAD_SHA")
+
+          echo "Changed files:"
+          printf ' - %s\n' "${CHANGED_FILES[@]}"
+
+          declare -A CLASS_CHANGED
+          CLASS_CHANGED_COUNT=0
+          RUN_ALL=0
+
+          mark_class_changed() {
+            local class_key="$1"
+            if [[ -z "${CLASS_CHANGED[$class_key]:-}" ]]; then
+              CLASS_CHANGED[$class_key]=1
+              CLASS_CHANGED_COUNT=$((CLASS_CHANGED_COUNT + 1))
+            fi
+          }
+
+          add_class_from_file() {
+            local file="$1"
+
+            case "$file" in
+              engine/class_modules/sc_death_knight.cpp|engine/class_modules/apl/apl_death_knight.*)
+                mark_class_changed deathknight
+                ;;
+              engine/class_modules/sc_demon_hunter.cpp|engine/class_modules/apl/apl_demon_hunter.*|engine/class_modules/apl/demon_hunter/*)
+                mark_class_changed demonhunter
+                ;;
+              engine/class_modules/sc_druid.cpp|engine/class_modules/apl/druid/*)
+                mark_class_changed druid
+                ;;
+              engine/class_modules/sc_evoker.cpp|engine/class_modules/apl/apl_evoker.*)
+                mark_class_changed evoker
+                ;;
+              engine/class_modules/sc_hunter.cpp|engine/class_modules/apl/apl_hunter.*)
+                mark_class_changed hunter
+                ;;
+              engine/class_modules/sc_mage.cpp|engine/class_modules/apl/mage.*)
+                mark_class_changed mage
+                ;;
+              engine/class_modules/monk/*|engine/class_modules/apl/apl_monk.*)
+                mark_class_changed monk
+                ;;
+              engine/class_modules/paladin/*|engine/class_modules/apl/apl_paladin.*)
+                mark_class_changed paladin
+                ;;
+              engine/class_modules/priest/*|engine/class_modules/apl/apl_priest.*)
+                mark_class_changed priest
+                ;;
+              engine/class_modules/sc_rogue.cpp|engine/class_modules/apl/apl_rogue.*)
+                mark_class_changed rogue
+                ;;
+              engine/class_modules/sc_shaman.cpp|engine/class_modules/apl/apl_shaman.*|engine/class_modules/apl/shaman/*)
+                mark_class_changed shaman
+                ;;
+              engine/class_modules/warlock/*|engine/class_modules/apl/warlock.*)
+                mark_class_changed warlock
+                ;;
+              engine/class_modules/sc_warrior.cpp|engine/class_modules/apl/apl_warrior.*)
+                mark_class_changed warrior
+                ;;
+              *)
+                RUN_ALL=1
+                ;;
+            esac
+          }
+
+          if (( ${#CHANGED_FILES[@]} == 0 )); then
+            RUN_ALL=1
+          elif (( RUN_ALL == 0 )); then
+            for file in "${CHANGED_FILES[@]}"; do
+              add_class_from_file "$file"
+              if (( RUN_ALL == 1 )); then
+                break
+              fi
+            done
+          fi
+
+          if (( RUN_ALL == 1 || CLASS_CHANGED_COUNT == 0 )); then
+            SELECTED_SPECS=("${ALL_SPECS[@]}")
+          else
+            SELECTED_SPECS=()
+            for spec in "${ALL_SPECS[@]}"; do
+              class_key="${spec%%_*}"
+              if [[ -n "${CLASS_CHANGED[$class_key]:-}" ]]; then
+                SELECTED_SPECS+=("$spec")
+              fi
+            done
+          fi
+
+          SPEC_JSON="["
+          for spec in "${SELECTED_SPECS[@]}"; do
+            if [[ "$SPEC_JSON" != "[" ]]; then
+              SPEC_JSON+=","
+            fi
+            SPEC_JSON+="\"$spec\""
+          done
+          SPEC_JSON+="]"
+
+          echo "spec-matrix=$SPEC_JSON" >> "$GITHUB_OUTPUT"
+          echo "Selected spec matrix: $SPEC_JSON"
+
   environment-configuration-info:
     runs-on: ubuntu-22.04
     steps:
@@ -34,20 +196,22 @@ jobs:
           echo "${{github.event.repository.default_branch}} ${{github.ref}} ${{github.ref_name}} ${{github.base_ref}} ${{github.head_ref}} ${{github.sha}}"
 
   spec-test:
-    needs: [build]
+    needs: [build, spec-test-selection]
     if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
     uses: ./.github/workflows/spec_test.yml
     with:
       cache-key: ubuntu-clang++-15-for_run-${{ github.sha }}-cpp-17
       is-ptr: false
+      spec-matrix: ${{ needs.spec-test-selection.outputs.spec-matrix }}
 
   spec-test-ptr:
-    needs: [build]
+    needs: [build, spec-test-selection]
     if: github.base_ref == github.event.repository.default_branch || github.ref_name == github.event.repository.default_branch
     uses: ./.github/workflows/spec_test.yml
     with:
       cache-key: ubuntu-clang++-15-for_run-${{ github.sha }}-cpp-17
       is-ptr: true
+      spec-matrix: ${{ needs.spec-test-selection.outputs.spec-matrix }}
 
   ubuntu-test:
     needs: [build]