Skip to content

Commit ec20294

Browse files
committed
[DK] Nazgrim's Conquest (allegedly) now triggers off free cost rune spenders
1 parent 4443450 commit ec20294

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

engine/class_modules/sc_death_knight.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12704,20 +12704,20 @@ double death_knight_t::resource_loss( resource_e resource_type, double amount, g
1270412704
if ( talent.rune_mastery.ok() )
1270512705
buffs.rune_mastery->trigger();
1270612706

12707+
if ( talent.rider.nazgrims_conquest.ok() && buffs.apocalyptic_conquest->check() )
12708+
{
12709+
debug_cast<buffs::apocalyptic_conquest_buff_t*>( buffs.apocalyptic_conquest )->nazgrims_conquest +=
12710+
as<int>( amount );
12711+
invalidate_cache( CACHE_STRENGTH );
12712+
}
12713+
1270712714
// Proc Chance does not appear to be in data, using testing data that is current as of 4/19/2024
1270812715
if ( talent.rider.riders_champion.ok() && rng().roll( 0.2 ) )
1270912716
summon_rider( spell.summon_whitemane_2->duration() );
1271012717

1271112718
// Effects that require the player to actually spend runes
1271212719
if ( actual_amount > 0 )
1271312720
{
12714-
if ( talent.rider.nazgrims_conquest.ok() && buffs.apocalyptic_conquest->check() &&
12715-
action->data().id() != spec.remorseless_winter->id() )
12716-
{
12717-
debug_cast<buffs::apocalyptic_conquest_buff_t*>( buffs.apocalyptic_conquest )->nazgrims_conquest +=
12718-
as<int>( amount );
12719-
invalidate_cache( CACHE_STRENGTH );
12720-
}
1272112721
}
1272212722
}
1272312723

engine/sim/proc_rng.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,8 @@ struct accumulated_rng_t : public proc_rng_t
281281

282282
void reset( reset_type_e reset_type ) override;
283283
int trigger( action_state_t* = nullptr ) override;
284+
void set_chance( double c )
285+
{ proc_chance = c; }
284286
};
285287

286288
// Threshold RNG rng helper class ==========================

0 commit comments

Comments
 (0)