From 65436bf8eb6e943ba6ecd0bafe904584630cf935 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Wed, 9 Jul 2025 12:32:44 -0700 Subject: [PATCH 1/4] ci: send a notification of scheduled failing tests --- .github/workflows/ci-build.yml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index ee8b29d5c..555483dda 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -8,6 +8,9 @@ on: branches: - main pull_request: + schedule: + - cron: "0 0 * * *" + workflow_dispatch: jobs: build: @@ -37,3 +40,18 @@ jobs: directory: coverage fail_ci_if_error: true verbose: true + notifications: + name: Regression notifications + runs-on: ubuntu-latest + needs: build + if: failure() && github.ref == 'refs/heads/main' && github.event_name != 'workflow_dispatch' + steps: + - name: Send notifications of failing tests + uses: slackapi/slack-github-action@b0fa283ad8fea605de13dc3f449259339835fc52 # v2.1.0 + with: + errors: true + webhook: ${{ secrets.SLACK_REGRESSION_FAILURES_WEBHOOK_URL }} + webhook-type: webhook-trigger + payload: | + action_url: "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" + repository: "${{ github.repository }}" From 3d5c5da7ea7c4825b154a8afa24695194f172a51 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Wed, 16 Jul 2025 10:54:25 -0700 Subject: [PATCH 2/4] test: assert false is true for the notification --- test/unit/App/basic.spec.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/unit/App/basic.spec.ts b/test/unit/App/basic.spec.ts index 855e9d7f7..24141a383 100644 --- a/test/unit/App/basic.spec.ts +++ b/test/unit/App/basic.spec.ts @@ -35,6 +35,8 @@ describe('App basic features', () => { const app = new MockApp({ token: '', signingSecret: '', port: 9999 }); // biome-ignore lint/complexity/useLiteralKeys: reaching into private fields assert.propertyVal(app['receiver'], 'port', 9999); + + assert.isTrue(false); }); it('should accept a port value under installerOptions', async () => { const MockApp = await importApp(overrides); From b7c93d4dbde907d2edf6bf40155be39fecfd0b83 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Wed, 16 Jul 2025 10:56:44 -0700 Subject: [PATCH 3/4] test: remove the main branch check for this pull request --- .github/workflows/ci-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index 555483dda..87f999b2b 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -44,7 +44,7 @@ jobs: name: Regression notifications runs-on: ubuntu-latest needs: build - if: failure() && github.ref == 'refs/heads/main' && github.event_name != 'workflow_dispatch' + if: failure() && github.event_name != 'workflow_dispatch' steps: - name: Send notifications of failing tests uses: slackapi/slack-github-action@b0fa283ad8fea605de13dc3f449259339835fc52 # v2.1.0 From 6687aaa0bff674c378f7899b3471ae2f08b9dc13 Mon Sep 17 00:00:00 2001 From: Eden Zimbelman Date: Wed, 16 Jul 2025 10:59:37 -0700 Subject: [PATCH 4/4] revert: remove changes made in testing --- .github/workflows/ci-build.yml | 2 +- test/unit/App/basic.spec.ts | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index 87f999b2b..555483dda 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -44,7 +44,7 @@ jobs: name: Regression notifications runs-on: ubuntu-latest needs: build - if: failure() && github.event_name != 'workflow_dispatch' + if: failure() && github.ref == 'refs/heads/main' && github.event_name != 'workflow_dispatch' steps: - name: Send notifications of failing tests uses: slackapi/slack-github-action@b0fa283ad8fea605de13dc3f449259339835fc52 # v2.1.0 diff --git a/test/unit/App/basic.spec.ts b/test/unit/App/basic.spec.ts index 24141a383..855e9d7f7 100644 --- a/test/unit/App/basic.spec.ts +++ b/test/unit/App/basic.spec.ts @@ -35,8 +35,6 @@ describe('App basic features', () => { const app = new MockApp({ token: '', signingSecret: '', port: 9999 }); // biome-ignore lint/complexity/useLiteralKeys: reaching into private fields assert.propertyVal(app['receiver'], 'port', 9999); - - assert.isTrue(false); }); it('should accept a port value under installerOptions', async () => { const MockApp = await importApp(overrides);