Skip to content

upgrade: filesystem package upgrade for Solid 2.0 #904

Open
davedbase wants to merge 3 commits into
solidjs-community:nextfrom
davedbase:update/v2/filesystem
Open

upgrade: filesystem package upgrade for Solid 2.0 #904
davedbase wants to merge 3 commits into
solidjs-community:nextfrom
davedbase:update/v2/filesystem

Conversation

@davedbase
Copy link
Copy Markdown
Member

@davedbase davedbase commented May 19, 2026

Mostly minor changes and remove of createResource

Summary by CodeRabbit

  • Chores
    • Major version bump to 2.0.0
    • Updated to require Solid.js 2.0.0-beta.13 and @solidjs/web as peer dependencies
    • Internal optimizations to filesystem reactive signal handling and async operations

Review Change Stack

@davedbase davedbase added this to the Solid 2.0 Migration milestone May 19, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

🦋 Changeset detected

Latest commit: ac37352

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/filesystem Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f5f8c679-4302-4720-be4f-0a9c289f4fb7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/filesystem/package.json`:
- Around line 62-70: The package currently imports `@solidjs/web` at runtime in
packages/filesystem/src/adapter-node.ts and
packages/filesystem/src/adapter-web.ts but only lists it in devDependencies;
update packages/filesystem/package.json to add "`@solidjs/web`" to
"peerDependencies" (matching the version used in devDependencies) so consumers
install the runtime dependency; ensure the version string matches the existing
"`@solidjs/web`" entry (e.g., "2.0.0-beta.13") and keep or remove the
devDependency entry as appropriate for local development.

In `@packages/filesystem/src/reactive.ts`:
- Around line 269-274: The readdir watcher cache is being corrupted by appending
the full path instead of the directory entry name; in the block using
readdirMap.get(getParentDir(path)) (variables: readdirMap, getParentDir,
readdirEntry, mutate, path) compute the entry name as the basename/last segment
of path (e.g. const name = path.split('/').pop() or use an existing basename
helper) and push that name into the cached items (mutate([...items, name] as
DirEntries)) rather than the full path so the readdir cache retains directory
entry names.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 614a40ea-4149-41e5-be99-11f6d0477b00

📥 Commits

Reviewing files that changed from the base of the PR and between 76d6f2e and 4e7f5bd.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • .changeset/filesystem-solid2-migration.md
  • packages/filesystem/package.json
  • packages/filesystem/src/adapter-node.ts
  • packages/filesystem/src/adapter-web.ts
  • packages/filesystem/src/reactive.ts
  • packages/filesystem/src/tools.ts
  • packages/filesystem/test/index.test.ts

Comment thread packages/filesystem/package.json Outdated
Comment thread packages/filesystem/src/reactive.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant