one-indexed-parameters must impact PageableHandlerMethodArgumentResolverSupport.getDefaultPageRequestFrom(...)

[hbenyoussef]

when activating the one indexed pageable parameter

spring:
  data:
    web:
      pageable:
        one-indexed-parameters: true

Any request with the page http parameter will get it value reduced by 1. ?page=5 become page=4 in pageable method parameter.
However, if the http parameter is missing, defaults values applies page=0.
If we add the @PageableDefault(page = 1), default value will be 1.
When using OpenAPI generator, specs like below
parameters: - name: page required: true in: query schema: type: integer default: 1 minimum: 1
will generate @PageableDefault(page = 1) which is wrong in HTTP request point of view.
The implementation of the PageableHandlerMethodArgumentResolverSupport.getDefaultPageRequestFrom(...) must take into account the one-indexed-parameters.

[AbaSheger]

Hi, I’d like to take a look at this.

From what I understand, when "one-indexed-parameters" is enabled, explicit "page" request parameters are adjusted from one-based to zero-based indexing, but the default page request created through "PageableHandlerMethodArgumentResolverSupport.getDefaultPageRequestFrom(...)" does not appear to apply the same adjustment.

My first step would be to reproduce the behavior with a focused test around "@PageableDefault(page = 1)" and "one-indexed-parameters=true", then check whether the default page calculation should be aligned with the explicit request parameter handling.

Does that sound like the right direction?