test: Improve the assertions for the restarter-no-unneeded-restart test (#395)

* test: Improve the assertions for the restarter-no-unneeded-restart test

* Remove generation = 3 assertion

Author: sbernauer

tests/templates/kuttl/restarter-no-unneeded-restart/01-assert.yaml

@@ -1,22 +1,8 @@
 ---
-apiVersion: kuttl.dev/v1beta1
-kind: TestAssert
-timeout: 180
-commands:
-  - script: |
-      kubectl -n $NAMESPACE rollout status sts/early --timeout=5m
-
-      read n1 t1 n2 t2 n3 t3 < <(
-        kubectl -n $NAMESPACE get pod early-{1,2,0} \
-          -o jsonpath='{range .items[*]}{.metadata.name}{" "}{.metadata.creationTimestamp}{" "}{end}'
-      )
-
-      if [[ "$t1" > "$t2" || "$t2" > "$t3" ]]; then
-        echo "ERROR: Pod creation order invalid:"
-        printf "  %s: %s\n  %s: %s\n  %s: %s\n" "$n1" "$t1" "$n2" "$t2" "$n3" "$t3"
-        exit 1
-      fi
-
-      echo "OK: Pod creation order verified:"
-      printf "  %s (%s)\n  %s (%s)\n  %s (%s)\n" "$n1" "$t1" "$n2" "$t2" "$n3" "$t3"
-      echo "  Asserted: $n1 <= $n2 <= $n3"
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+  name: early
+status:
+  readyReplicas: 3
+  replicas: 3

tests/templates/kuttl/restarter-no-unneeded-restart/02-assert.yaml

@@ -1,22 +1,9 @@
 ---
-apiVersion: kuttl.dev/v1beta1
-kind: TestAssert
-timeout: 180
-commands:
-  - script: |
-      kubectl -n $NAMESPACE rollout status sts/late --timeout=5m
-
-      read n0 t0 n1 t1 n2 t2 < <(
-        kubectl -n $NAMESPACE get pod late-{0,1,2} \
-          -o jsonpath='{range .items[*]}{.metadata.name}{" "}{.metadata.creationTimestamp}{" "}{end}'
-      )
-
-      if [[ "$t0" > "$t1" || "$t1" > "$t2" ]]; then
-        echo "ERROR: Pod creation order invalid:"
-        printf "  %s: %s\n  %s: %s\n  %s: %s\n" "$n0" "$t0" "$n1" "$t1" "$n2" "$t2"
-        exit 1
-      fi
-
-      echo "OK: Pod creation order verified:"
-      printf "  %s (%s)\n  %s (%s)\n  %s (%s)\n" "$n0" "$t0" "$n1" "$t1" "$n2" "$t2"
-      echo "  Asserted: $n0 <= $n1 <= $n2"
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+  name: late
+  generation: 1
+status:
+  readyReplicas: 3
+  replicas: 3