starknet_os_flow_tests: cover all proof versions and program hashes#14042
Conversation
PR SummaryMedium Risk Overview Stabilizes and hardens test/infra: makes Operational tweaks: increases CI Reviewed by Cursor Bugbot for commit 375c852. Bugbot is set up for automated code reviews on this repo. Configure here. |
b5abe57 to
e90b356
Compare
de6cd6b to
552cdef
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Do we have any negative tests?
One for not virual os hash and one for proof version?
@AvivYossef-starkware reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).
crates/starknet_os_flow_tests/src/tests.rs line 3032 at r1 (raw file):
let test_contract = FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)); let (mut test_builder, [test_contract_address]) = TestBuilder::create_standard([(test_contract, calldata![Felt::ZERO, Felt::ZERO])]).await;
what is it?
Code quote:
calldata![Felt::ZERO, Felt::ZERO]32350e2 to
6fcaefc
Compare
552cdef to
3210a0e
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on AvivYossef-starkware).
crates/starknet_os_flow_tests/src/tests.rs line 3032 at r1 (raw file):
Previously, AvivYossef-starkware wrote…
what is it?
Args for the constructor. Same pattern as in other tests here
Yoni-Starkware
left a comment
There was a problem hiding this comment.
We don't have negative tests for the OS. We have negative unit tests for the blockifier
I added negative tests for the VIRTUAL OS since it's user-facing
@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on AvivYossef-starkware).
3210a0e to
5d66a74
Compare
|
Artifacts upload workflows: |
80f6045 to
0bd2e48
Compare
5d66a74 to
b22c491
Compare
0bd2e48 to
af06eb0
Compare
b22c491 to
ac8abb5
Compare
Adds a Cairo1 flow test that submits an invoke transaction for every (ProofVersion, allowed_virtual_os_program_hash) pair, exercising the PROOF_VERSION_V0/V1 acceptance path through check_proof_facts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ac8abb5 to
375c852
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
@AvivYossef-starkware reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
@AvivYossef-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).
crates/starknet_os_flow_tests/src/tests.rs line 3032 at r3 (raw file):
let test_contract = FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)); let (mut test_builder, [test_contract_address]) = TestBuilder::create_standard([(test_contract, calldata![Felt::ZERO, Felt::ZERO])]).await;
Code quote:
[Felt::ZERO, Felt::ZERO])]
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
Summary
check_proof_facts.Test plan
cargo test -p starknet_os_flow_tests test_proof_facts_versions_and_program_hashes🤖 Generated with Claude Code