You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more
Medium Risk
Adds a new end-to-end test that asserts measured OS syscall/tx overhead matches VersionedConstants, which may be sensitive to small resource-count drift and can become flaky when execution internals change.
Overview Adds an OS resource regression test. Introduces test_os_resources that runs a small block with an OsResourcesTest invoke plus invoke/declare/deploy_account/L1 handler measurements, extracts OS-overhead resources from traces, and compares them against VersionedConstants::latest_constants().os_resources.
Updates resource-extraction plumbing by switching extract_execute_txs_inner_resources to consume CentralTransactionExecutionInfo and reusing helper functions in os_resources.rs for syscall/tx extraction and margin-based comparison.
Reviewed by Cursor Bugbot for commit a669b90. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.