Skip to content

starknet_os_flow_tests: add test_os_resources#14094

Closed
dorimedini-starkware wants to merge 1 commit into
05-19-blockifier_test_utils_fix_os_resources_test_contract_to_accept_self_address_in_calldatafrom
05-19-starknet_os_flow_tests_add_test_os_resources
Closed

starknet_os_flow_tests: add test_os_resources#14094
dorimedini-starkware wants to merge 1 commit into
05-19-blockifier_test_utils_fix_os_resources_test_contract_to_accept_self_address_in_calldatafrom
05-19-starknet_os_flow_tests_add_test_os_resources

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 19, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 19, 2026

PR Summary

Medium Risk
Adds a new end-to-end test that asserts measured OS syscall/tx overhead matches VersionedConstants, which may be sensitive to small resource-count drift and can become flaky when execution internals change.

Overview
Adds an OS resource regression test. Introduces test_os_resources that runs a small block with an OsResourcesTest invoke plus invoke/declare/deploy_account/L1 handler measurements, extracts OS-overhead resources from traces, and compares them against VersionedConstants::latest_constants().os_resources.

Updates resource-extraction plumbing by switching extract_execute_txs_inner_resources to consume CentralTransactionExecutionInfo and reusing helper functions in os_resources.rs for syscall/tx extraction and margin-based comparison.

Reviewed by Cursor Bugbot for commit a669b90. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants