Skip to content

blockifier: add CallInfo::get_visited_contract_addresses#14101

Merged
yoavGrs merged 1 commit into
mainfrom
accessed-keys-visited-contract-addresses
May 20, 2026
Merged

blockifier: add CallInfo::get_visited_contract_addresses#14101
yoavGrs merged 1 commit into
mainfrom
accessed-keys-visited-contract-addresses

Conversation

@yoavGrs
Copy link
Copy Markdown
Contributor

@yoavGrs yoavGrs commented May 19, 2026

Mirrors the Python state-selector walk that drives the OS contracts-trie
input set. Yields the call's own storage_address, its code_address when set
(delegate-style calls), and the contents of
storage_access_tracker.accessed_contract_addresses. No new field is added —
the data is derived from existing CallEntryPoint and StorageAccessTracker
fields. Inner calls are not traversed by this method — use CallInfo::iter
to walk the tree.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 19, 2026

PR Summary

Low Risk
Low risk: adds a new accessor method derived from existing execution tracking data without changing execution behavior or state updates.

Overview
Adds CallInfo::get_visited_contract_addresses, an iterator that reports the contract addresses whose contracts-trie leaves are needed to replay a call (including the call’s storage_address, optional code_address for delegate-style calls, and addresses recorded by get_class_hash_at).

This is a read-only helper that does not traverse inner calls (callers should use CallInfo::iter to walk the call tree when needed).

Reviewed by Cursor Bugbot for commit 74e1e2a. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ArielElp reviewed 1 file and made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on yoavGrs).

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@yoavGrs yoavGrs force-pushed the accessed-keys-visited-contract-addresses branch from a0228f5 to 066d324 Compare May 20, 2026 11:50
@yoavGrs yoavGrs force-pushed the accessed-keys-extract-storage-entries branch from bb4ce82 to 59f8b30 Compare May 20, 2026 11:50
@yoavGrs yoavGrs changed the base branch from accessed-keys-extract-storage-entries to main May 20, 2026 12:31
Mirrors the Python state-selector walk that drives the OS contracts-trie
input set. Yields the call's own storage_address, its code_address when set
(delegate-style calls), and the contents of
storage_access_tracker.accessed_contract_addresses. No new field is added —
the data is derived from existing CallEntryPoint and StorageAccessTracker
fields. Inner calls are not traversed by this method — use CallInfo::iter
to walk the tree.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@yoavGrs yoavGrs force-pushed the accessed-keys-visited-contract-addresses branch from 066d324 to 74e1e2a Compare May 20, 2026 12:31
@github-actions
Copy link
Copy Markdown

Artifacts upload workflows:

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 20, 2026

Merge activity

  • May 20, 12:32 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@yoavGrs yoavGrs added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 1bec947 May 20, 2026
39 of 42 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants