apollo_storage: delete dead code#14107
Open
asaf-sw wants to merge 1 commit into
Open
Conversation
Remove begin_persistent_rw_txn() and OwnedDbWriteTransaction from db/mod.rs. Both were annotated with #[allow(dead_code)] and have zero callers across the entire codebase. The struct used unsafe transmute to extend a transaction lifetime, and the method was the only way to construct it.
|
This change is |
|
Artifacts upload workflows: |
dorimedini-starkware
approved these changes
May 20, 2026
Collaborator
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dan-starkware).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
begin_persistent_rw_txn()andOwnedDbWriteTransactionfromcrates/apollo_storage/src/db/mod.rs.Both were annotated with
#[allow(dead_code)]and have zero callers anywhere in the codebase:begin_persistent_rw_txn(): a method onDbWriterthat usedunsafe { std::mem::transmute(...) }to extend a transaction's lifetime to'static. It was written for a "persistent transaction" pattern in batching mode, but was never wired up.OwnedDbWriteTransaction: the struct returned bybegin_persistent_rw_txn(), which held anArc<Environment>to keep the environment alive. Deleting the constructor makes the struct unreachable, so both are removed together.Generated by Claude Code