You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Introduces new Cairo0 hashing logic and cross-language parity tests; risk is mainly around subtle serialization/mod-reduction mismatches that could break downstream verifier assumptions. Changes are otherwise isolated to test-program compilation and test coverage.
Overview
Adds a new Cairo0 test program qm31_blake that computes a Blake2s-256 digest over QM31 inputs (serialized as 4 LE u32 limbs per element) and reduces the 8 digest words modulo 2^31-1.
Wires this program into the test-program build (compile_program.rs + QM31_BLAKE_BYTES) and adds a Rust reference implementation plus a parity test in blake2s_test.rs to assert Cairo output matches the expected QM31 hashing semantics across several cases.
Reviewed by Cursor Bugbot for commit 143bc30. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.