blockifier: take CommitmentStateDiff in AccessedKeys::new and predicted_alias_storage_entries

[yoavGrs]

CommitmentStateDiff is the natural per-block state-diff type at the OS-replay
boundary (the batcher's BlockExecutionArtifacts already carries one). Swap
both AccessedKeys::new and predicted_alias_storage_entries to consume it
directly:

• AccessedKeys::new derives storage entries from
  state_diff.storage_updates, the modified-contracts union from
  storage_updates / address_to_nonce / address_to_class_hash, and the
  class-hash keys from address_to_class_hash + class_hash_to_compiled_class_hash.
• predicted_alias_storage_entries now walks CommitmentStateDiff directly;
  the parity test converts its StateMaps fixture via CommitmentStateDiff::from.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

[reviewable-StarkWare]

This change is 

[yoavGrs]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_os_flow_tests: drive commitment keys from compute_accessed_keys #14106
• apollo_storage,apollo_batcher,apollo_reverts: write accessed keys instead of tx execution infos #14105
• blockifier: take CommitmentStateDiff in AccessedKeys::new and predicted_alias_storage_entries #14156 👈 (View in Graphite)
• apollo_batcher: record ProofFacts block_number per tx #14104
• blockifier: add compute_accessed_keys and AccessedKeys #14103
• blockifier: add predicted_alias_storage_entries #14102
• blockifier: add CallInfo::get_visited_contract_addresses #14101
• apollo_integration_tests: add shared proof-flow infrastructure (#13760) #14100
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Medium Risk
Touches OS replay input derivation (AccessedKeys/alias prediction), so mistakes could cause missing trie reads or incorrect stateful compression behavior, but changes are largely mechanical type/field mapping with updated tests.

Overview
AccessedKeys::new and predicted_alias_storage_entries now take CommitmentStateDiff directly (instead of StateMaps) and derive accessed storage entries/contracts/class hashes from its storage_updates, address_to_nonce, address_to_class_hash, and class_hash_to_compiled_class_hash fields.

Tests are updated to build CommitmentStateDiff fixtures and the alias-prediction parity test converts from StateMaps via CommitmentStateDiff::from to keep predicted vs. actual alias-contract accesses aligned.

^{Reviewed by Cursor Bugbot for commit f457985. Bugbot is set up for automated code reviews on this repo. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on yoavGrs).

---

crates/blockifier/src/state/stateful_compression.rs line 98 at r1 (raw file):

        .keys()
        .chain(state_diff.address_to_nonce.keys())
        .chain(state_diff.address_to_class_hash.keys());

this is implemented twice; make this a method of CommitmentStateDiff?

Code quote:

    let modified_contracts = state_diff
        .storage_updates
        .keys()
        .chain(state_diff.address_to_nonce.keys())
        .chain(state_diff.address_to_class_hash.keys());