Skip to content

starknet_transaction_prover: redact URL credentials in logs and add startup banner#14164

Open
avi-starkware wants to merge 1 commit into
avi/prover-v3/healthfrom
avi/prover-v3/redact-banner
Open

starknet_transaction_prover: redact URL credentials in logs and add startup banner#14164
avi-starkware wants to merge 1 commit into
avi/prover-v3/healthfrom
avi/prover-v3/redact-banner

Conversation

@avi-starkware
Copy link
Copy Markdown
Collaborator

Adds redact_url_host which collapses a URL to scheme://host[:port],
dropping userinfo, path, and query. The CLI-override logs for
rpc_node_url and blocking_check_url and a new startup banner all
route through it so credentials embedded in those URLs cannot reach a log
sink.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

…tartup banner

Adds `redact_url_host` which collapses a URL to `scheme://host[:port]`,
dropping userinfo, path, and query. The CLI-override logs for
`rpc_node_url` and `blocking_check_url` and a new startup banner all
route through it so credentials embedded in those URLs cannot reach a log
sink.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Observability-only changes; runtime proving, RPC, and auth behavior are unchanged.

Overview
Introduces redact_url_host, which logs URLs as scheme://host[:port] only—stripping userinfo, path, query, and fragment—and uses "<invalid url>" on parse failure so raw strings never hit logs.

CLI override messages for rpc_node_url and blocking_check_url now log through this helper instead of full URLs. A new startup info! banner records version, git SHA, chain id, redacted RPC host, fee-validation and blocking-check flags, and OHTTP enablement without sensitive URL parts.

Unit tests cover credentials, default ports, fragments, and invalid input.

Reviewed by Cursor Bugbot for commit 948a1e9. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants