starknet_transaction_prover: Prometheus /metrics endpoint with build_info#14167
starknet_transaction_prover: Prometheus /metrics endpoint with build_info#14167avi-starkware wants to merge 1 commit into
Conversation
PR SummaryLow Risk Overview
When Reviewed by Cursor Bugbot for commit 5eb413f. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9c4a5a0. Configure here.
|
|
||
| fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> { | ||
| self.inner.poll_ready(cx) | ||
| } |
There was a problem hiding this comment.
poll_ready delegates to inner but call may skip it
Medium Severity
MetricsService::poll_ready delegates to self.inner.poll_ready(cx), but call short-circuits for GET /metrics without ever invoking self.inner.call(). This consumes the inner service's readiness without a matching call, which can leak permits or slots in any inner service with stateful backpressure (e.g., Buffer, ConcurrencyLimit). The existing HealthService already handles this correctly by returning Poll::Ready(Ok(())) directly and not delegating to the inner service.
Reviewed by Cursor Bugbot for commit 9c4a5a0. Configure here.
…info Adds `MetricsLayer` that short-circuits `GET /metrics` with a Prometheus text-format scrape, and an `install_exporter` helper that registers the global recorder and emits `prover_build_info` with version + git_sha labels. Wired alongside `HealthLayer` so the scrape path bypasses the JSON-RPC parser. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
9c4a5a0 to
5eb413f
Compare



Adds
MetricsLayerthat short-circuitsGET /metricswith a Prometheustext-format scrape, and an
install_exporterhelper that registers theglobal recorder and emits
prover_build_infowith version + git_shalabels. Wired alongside
HealthLayerso the scrape path bypasses theJSON-RPC parser.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com