Skip to content

starknet_transaction_prover: origin-level breadcrumbs for validation errors#14172

Open
avi-starkware wants to merge 1 commit into
avi/prover-v3/saturation-healthfrom
avi/prover-v3/error-origin-logs
Open

starknet_transaction_prover: origin-level breadcrumbs for validation errors#14172
avi-starkware wants to merge 1 commit into
avi/prover-v3/saturation-healthfrom
avi/prover-v3/error-origin-logs

Conversation

@avi-starkware
Copy link
Copy Markdown
Collaborator

Splits validation-error logging so each origin (request body, RPC,
proving) carries an event tag and trimmed payload context, making it
straightforward to root-cause production failures from the structured
log stream. Also adds an in-test microbenchmark for HttpMetricsLayer
overhead so any regression in the hot path is visible.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Observability-only logging changes and test-gated benchmarks; no proving, auth, or transaction-handling logic changes.

Overview
Adds structured validation warnings in virtual_snos_prover so each early reject logs event = "validation_error" with a stable reason (pending_block_unsupported, non_invoke_transaction, invalid_transaction_input) via inspect_err, without logging transaction calldata.

Updates the RPC layer’s prove failure log to event = "prove_transaction_failed" with outcome from metric_outcome(), matching prover_prove_transaction_outcome_total for log/metric correlation.

Introduces an ignored in-test microbenchmark (server::overhead_bench) comparing a no-layer baseline to HttpMetricsLayer steady-state per-request overhead (50k ops, release + --ignored).

Reviewed by Cursor Bugbot for commit eba2906. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

…errors

Splits validation-error logging so each origin (request body, RPC,
proving) carries an `event` tag and trimmed payload context, making it
straightforward to root-cause production failures from the structured
log stream. Also adds an in-test microbenchmark for HttpMetricsLayer
overhead so any regression in the hot path is visible.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@avi-starkware avi-starkware force-pushed the avi/prover-v3/error-origin-logs branch from e57d84d to eba2906 Compare May 24, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants