fix: preflight schemas apply correctly when chained before for#15863
Open
PranavAgarkar07 wants to merge 3 commits into
Open
fix: preflight schemas apply correctly when chained before for#15863PranavAgarkar07 wants to merge 3 commits into
for#15863PranavAgarkar07 wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 726971e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
reviewed
May 18, 2026
| "@sveltejs/kit": patch | ||
| --- | ||
|
|
||
| fix: add `null` to `RemoteFormInput` type to allow nullable schema validators |
Member
There was a problem hiding this comment.
I think this PR may accidentally have pulled in changes from #15859 which we should be separate
teemingc
requested changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15746
Root cause
preflight()andfor()live in different closure scopes.preflight()is defined insidecreate_instance()and stores the preflight schema in that closure.for()is defined on the outerinstanceaftercreate_instance()returns — when called, it creates/reuses a different cachedcreate_instance(key)instance whose closure haspreflight_schema = undefined.This means
createPost.preflight(schema).for("some id")silently drops the preflight schema, whilecreatePost.for("some id").preflight(schema)works correctly because both methods operate on the same instance.Fix
Used a
WeakMapin theform()scope to track preflight schemas per instance. Bothpreflight()(insidecreate_instance) andfor()(on the outer instance) share access to this map:preflight()stores the schema keyed by the current instancefor()checks if the calling instance has a preflight schema in the map and propagates it to the new instance viaentry.instance.preflight(schema)Test
Added a new E2E test page at
/remote/form/preflight-forthat validatespreflight().for('id')works end-to-end.Verification
pnpm check— passes (0 errors)pnpm -F @sveltejs/kit test:unit— 537/537 passpnpm prepublishOnly— types generate cleanlypnpm run lint— linting cleanPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits