fix: log actual adapter-node listening address#15899
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 21eb8d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15880
This fixes the
adapter-nodestartup log so it uses the actual bound server address instead of manually echoing the configured host and port.That matters when
PORT=0, because Node binds an available random port and the old log still printed port0. The new helper also formats IPv6 hosts with brackets so the logged address is a valid URL.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkScoped adapter-node commands run:
pnpm --dir packages/adapter-node testpnpm --dir packages/adapter-node lintpnpm --dir packages/adapter-node checkpnpm --dir packages/adapter-node buildpnpm exec prettier --check .changeset/twelve-buses-smile.md packages/adapter-node/src/index.js packages/adapter-node/utils.js packages/adapter-node/tests/utils.spec.tspnpm exec eslint --cache --cache-location node_modules/.eslintcache packages/adapter-node/src/index.js packages/adapter-node/utils.js packages/adapter-node/tests/utils.spec.tsgit diff --checkThe focused regression test failed before the fix because
format_listening_addressdid not exist, then passed after the runtime helper was added.Changesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Added a patch changeset for
@sveltejs/adapter-node.Edits