When a Thor command doesn't exist, print command not found instead of

throwing an exception

Author: bradgessler

gem/terminalwire-rails/lib/terminalwire/rails.rb

@@ -90,16 +90,15 @@ def handle(adapter:, env:)
           case message
           in { event: "initialization", protocol:, program: { arguments: }, entitlement: }
             context = Terminalwire::Server::Context.new(adapter:, entitlement:)
+            exit_code = 0
 
             begin
               @cli_class.terminalwire arguments:, context: do |cli|
                 cli.default_url_options = { host: env["HTTP_HOST"] }
               end
-              context.exit
-            # rescue Thor::InvocationError => e
-            #   context.stdin.puts e.message
-            #   context.exit(1)
-            rescue StandardError => e
+            rescue ::Thor::UndefinedCommandError => e
+              context.stdout.puts e.message
+            rescue ::StandardError => e
               # Log the error
               handler_error_message = <<~_
                 An error occured handling message in #{self.class.name}: #{e.inspect}
@@ -120,7 +119,9 @@ def handle(adapter:, env:)
                 # Show a generic message in production
                 context.stderr.puts error_message
               end
-              context.exit 1
+              exit_code = 1
+            ensure
+              context.exit exit_code
             end
           end
         end
@@ -158,10 +159,9 @@ def self.included(base)
     end
 
     module ClassMethods
-      def terminalwire(arguments:, context:)
-        dispatch(nil, arguments.dup, nil, shell: Shell.new(context)) do |instance|
-          yield instance if block_given?
-        end
+      # Use the extend Rails shell with this shell
+      def terminalwire_shell(context)
+        Terminalwire::Thor::Shell.new(context)
       end
     end
   end

gem/terminalwire-server/lib/terminalwire/server/thor.rb

@@ -57,10 +57,17 @@ def fail(...)
       end
 
       module ClassMethods
-        def start(given_args = ARGV, config = {})
-          context = config.delete(:context)
-          config[:shell] = Shell.new(context) if context
-          super(given_args, config)
+        def terminalwire(arguments:, context:)
+          # I have to manually hack into the Thor dispatcher to get access to the instance
+          # of the CLI so I can slap the Rails helper methods in there, or other helpes
+          # raise [context.inspect, arguments.inspect, self.inspect].inspect
+          dispatch(nil, arguments.dup, nil, shell: terminalwire_shell(context)) do |instance|
+            yield instance
+          end
+        end
+
+        def terminalwire_shell(context)
+          Terminalwire::Server::Thor::Shell.new(context)
         end
       end
     end

spec/integration/rails_spec.rb

@@ -49,6 +49,16 @@ def console(&)
     end
   end
 
+  it "runs unknown commands" do
+    console do |repl|
+      repl.puts "#{BINARY_NAME} nothingburger"
+      repl.gets.tap do |buffer|
+        expect(buffer).to include("Could not find command \"nothingburger\".")
+        expect(buffer).to_not include("Thor::UndefinedCommandError")
+      end
+    end
+  end
+
   private
 
   def wait_for_server_in_container(timeout:)