Skip to content

Commit 37936d9

Browse files
buf: remove unnecessary cache operation
All control structures of buffers shared between cores are now stoerd in a non-cached memory alias. Cache writeback is no longer needed here Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
1 parent cbb350a commit 37936d9

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

src/audio/pipeline/pipeline-graph.c

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -409,17 +409,7 @@ int pipeline_for_each_comp(struct comp_dev *current,
409409
continue;
410410

411411
/* don't go back to the buffer which already walked */
412-
/*
413-
* Note, that this access must be performed unlocked via
414-
* uncached address. Trying to lock before checking the flag
415-
* understandably leads to a deadlock when this function is
416-
* called recursively from .comp_func() below. We do it in a
417-
* safe way: this flag must *only* be accessed in this function
418-
* only in these three cases: testing, setting and clearing.
419-
* Note, that it is also assumed that buffers aren't shared
420-
* across CPUs. See further comment below.
421-
*/
422-
dcache_writeback_invalidate_region(uncache_to_cache(buffer), sizeof(*buffer));
412+
423413
if (buffer->audio_buffer.walking)
424414
continue;
425415

0 commit comments

Comments
 (0)