[Bug]: Video2Commons fail during login: OAuthException Unexpect request token key

[Mathglot]

Contact Details

mathglot7@gmail.com

What happened?

Following instructions at https://commons.wikimedia.org/wiki/Commons:Video2commons, and attempting to execute step 1, Visit https://video2commons.toolforge.org/ and log in. It went to an Oauth page with a pop-up dialog which asked permission to allow the app access to whatever, and I clicked the button. Within a few seconds, I got a traceback error message. I will try the same thing on another browser, to see what happens.

Expected: login to complete, so I could continue to Step 2, but it never got that far.

What browser(s) are you experiencing the problem on?

7.7.3851.66 (Official Build) (64-bit), Chromium Version 142.0.7444.245. Windows 10 Version 22H2 (Build 19045.6466)

Relevant error messages

Traceback (most recent call last):
  File "/data/project/video2commons/www/python/venv/lib/python3.11/site-packages/flask/app.py", line 917, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/project/video2commons/www/python/venv/lib/python3.11/site-packages/flask/app.py", line 902, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/project/video2commons/www/python/src/../../../video2commons/frontend/app.py", line 231, in logincallback
    access_token = handshaker.complete(request_token, request.query_string)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/project/video2commons/www/python/venv/lib/python3.11/site-packages/mwoauth/handshaker.py", line 106, in complete
    return complete(
           ^^^^^^^^^
  File "/data/project/video2commons/www/python/venv/lib/python3.11/site-packages/mwoauth/functions.py", line 161, in complete
    raise OAuthException(
mwoauth.errors.OAuthException: Unexpect request token key '5bcfb07d864892400e6f7aa07f4956ba', expected '9b669f05cda5d0cd893ccf90ce4f8b56'.

Follow-up on another browser

I am trying on Opera One (version: 125.0.5729.49) and it got past the OAuth step no problem (and is now sitting there with 'your task is pending'; not clear if anything is happening, but the bug did not occur).

[Amdrel]

Thank you for taking the time to file a report!

Using Chromium (version 143.0.7499.193) I wasn't able to reproduce the issue following the typical login flow. However, I was able to experience this problem if I started login in two different tabs and completed it in the first, which from your description I am doubtful you triggered it that way.

Opera One uses the same engine as Chromium so it shouldn't be due to an incompatibility there. It may be possible you have an extension interfering with the login process if it's still not working after a 2nd attempt. You could try clearing your cookies as well, but the login process does this already so I'm doubtful that would fix it.

[don-vip]

If I remember correctly, v2c is only available to autopatrolled users (>= 500 edits on Commons), maybe this check is broken.

[Amdrel]

I don't have a quick way to check that on the production instance, but I'll see if I can do it with my local version of V2C. As far as I know, alt accounts are prohibited unless they are bots.

[Amdrel]

The check is working as expected for me. Also, the threshold is currently 50 and not 500 which means that Mathglot should be eligible (currently at 357 edits).