fix(webapp): conform v1 form fixes from review

Address CodeRabbit feedback on the conform 1.x migration: use defaultValue
(not value) on hidden inputs so they stay uncontrolled, return the env-var
project-lookup failure as a form-level error, join multi-message field
errors when rendering, and clone alerts.emails before using it as mutable
field-list state.

Author: carderne

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables.new/route.tsx

@@ -164,7 +164,7 @@ export const action = dashboardAction(
       },
     });
     if (!project) {
-      return json(submission.reply({ fieldErrors: { key: ["Project not found"] } }));
+      return json(submission.reply({ formErrors: ["Project not found"] }));
     }
 
     const repository = new EnvironmentVariablesRepository(prisma);

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.settings.integrations/route.tsx

@@ -499,7 +499,9 @@ function BuildSettingsForm({ buildSettings }: { buildSettings: BuildSettings })
             Command to install your project dependencies. This will be run from the root directory
             of your repo. Auto-detected by default.
           </Hint>
-          <FormError id={fields.installCommand.errorId}>{fields.installCommand.errors}</FormError>
+          <FormError id={fields.installCommand.errorId}>
+            {fields.installCommand.errors?.join(", ")}
+          </FormError>
         </InputGroup>
         <InputGroup fullWidth>
           <Label htmlFor={fields.preBuildCommand.id}>Pre-build command</Label>
@@ -518,7 +520,9 @@ function BuildSettingsForm({ buildSettings }: { buildSettings: BuildSettings })
             Any command that needs to run before we build and deploy your project. This will be run
             from the root directory of your repo.
           </Hint>
-          <FormError id={fields.preBuildCommand.errorId}>{fields.preBuildCommand.errors}</FormError>
+          <FormError id={fields.preBuildCommand.errorId}>
+            {fields.preBuildCommand.errors?.join(", ")}
+          </FormError>
         </InputGroup>
         <div className="border-t border-grid-dimmed pt-4">
           <InputGroup>

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-alerts/route.tsx

@@ -228,7 +228,7 @@ function BillingAlerts({ alerts }: { alerts: BillingAlertsData["alerts"] }) {
   });
   const { emails, amount, alertLevels } = fields;
 
-  const fieldValues = useRef<string[]>(alerts.emails);
+  const fieldValues = useRef<string[]>([...alerts.emails]);
   const emailFields = emails.getFieldList();
 
   const checkboxLevels = [0.75, 0.9, 1.0, 2.0, 5.0];

apps/webapp/app/routes/_app.orgs.$organizationSlug_.projects.new/route.tsx

@@ -388,9 +388,9 @@ export default function Page() {
                   <FormError id={projectName.errorId}>{projectName.errors}</FormError>
                 </InputGroup>
                 {canCreateV3Projects ? (
-                  <input {...getInputProps(projectVersion, { type: "hidden" })} value={"v3"} />
+                  <input {...getInputProps(projectVersion, { type: "hidden" })} defaultValue={"v3"} />
                 ) : (
-                  <input {...getInputProps(projectVersion, { type: "hidden" })} value={"v2"} />
+                  <input {...getInputProps(projectVersion, { type: "hidden" })} defaultValue={"v2"} />
                 )}
 
                 <div className="border-t border-charcoal-700" />