Skip to content

Implement setMinPINLength command and minPinLength extension#59

Open
robin-nitrokey wants to merge 8 commits into
mainfrom
min-pin-length
Open

Implement setMinPINLength command and minPinLength extension#59
robin-nitrokey wants to merge 8 commits into
mainfrom
min-pin-length

Conversation

@robin-nitrokey
Copy link
Copy Markdown
Member

This is cherry-picked from #54.

To do:

  • Fix size for data in authenticator_config
  • Handle new_value === self.min_pin_length() correctly in PersistentState::set_min_pin_length (no error, but also no unnecessary write)
  • Handle forceChangePin in config_set_min_pin_length
  • Don’t reset force_pin_change in PersistentState::set_pin if the hash has not changed
  • Fix PIN length check #43
  • Rename authenticator_config to config ctap-types#79
  • Add tests

To decide:

  • Should we store the PIN length?

cc @0x0ece

@robin-nitrokey robin-nitrokey mentioned this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants