diff --git a/web/Areas/ClinicalScheduler/Controllers/RotationsController.cs b/web/Areas/ClinicalScheduler/Controllers/RotationsController.cs index fac532700..8355dfa71 100644 --- a/web/Areas/ClinicalScheduler/Controllers/RotationsController.cs +++ b/web/Areas/ClinicalScheduler/Controllers/RotationsController.cs @@ -497,16 +497,18 @@ private object BuildWeekScheduleItem(WeekDto week, IEnumerable s.WeekId == week.WeekId) - .Select(i => new + .Select(i => { - instructorScheduleId = i.InstructorScheduleId, - firstName = personData.ContainsKey(i.MothraId) ? personData[i.MothraId].PersonDisplayFirstName : "Unknown", - lastName = personData.ContainsKey(i.MothraId) ? personData[i.MothraId].PersonDisplayLastName : "Unknown", - fullName = personData.ContainsKey(i.MothraId) - ? personData[i.MothraId].PersonDisplayFullName - : $"Person {i.MothraId}", - mothraId = i.MothraId, - isPrimaryEvaluator = i.Evaluator + personData.TryGetValue(i.MothraId, out var p); + return new + { + instructorScheduleId = i.InstructorScheduleId, + firstName = p?.PersonDisplayFirstName ?? "Unknown", + lastName = p?.PersonDisplayLastName ?? "Unknown", + fullName = p?.PersonDisplayFullName ?? $"Person {i.MothraId}", + mothraId = i.MothraId, + isPrimaryEvaluator = i.Evaluator + }; }) .ToList(); diff --git a/web/Areas/RAPS/Services/RAPSAuditService.cs b/web/Areas/RAPS/Services/RAPSAuditService.cs index eda28d872..9006ab3e2 100644 --- a/web/Areas/RAPS/Services/RAPSAuditService.cs +++ b/web/Areas/RAPS/Services/RAPSAuditService.cs @@ -150,9 +150,8 @@ public async Task> GetMemberRolesAndPermissionHistory(string inst string key = auditLog?.RoleId != null ? "role-" + auditLog.RoleId : "permission-" + auditLog!.PermissionId; - if (actionsPerformedOnObject.ContainsKey(key)) + if (actionsPerformedOnObject.TryGetValue(key, out var moreRecentActions)) { - List moreRecentActions = actionsPerformedOnObject[key]; bool undone = false; switch (auditLog.Audit) { diff --git a/web/Areas/RAPS/Services/VMACSExport.cs b/web/Areas/RAPS/Services/VMACSExport.cs index ce945db4d..70c0fae17 100644 --- a/web/Areas/RAPS/Services/VMACSExport.cs +++ b/web/Areas/RAPS/Services/VMACSExport.cs @@ -300,8 +300,8 @@ private List GetExportUsers(List users, string rolePr exportUsers[^1].AccessCodes = accessCodesBuilder.ToString(); } accessCodesBuilder.Clear(); - string permissionIdList = permissionsByMemberId.ContainsKey(user.MothraId.Trim()) - ? permissionsByMemberId[user.MothraId.Trim()] + string permissionIdList = permissionsByMemberId.TryGetValue(user.MothraId.Trim(), out var permIds) + ? permIds : ""; exportUsers.Add(new VMACSExportUser() { @@ -342,7 +342,7 @@ private string GetDefaultServer() private string GetServerUrl(string instance, string server) { string key = instance.ToLower() + "-" + server.ToLower(); - return _vmacsServers.ContainsKey(key) ? _vmacsServers[key] : ""; + return _vmacsServers.TryGetValue(key, out var url) ? url : ""; } private static void RecordMessage(List messages, string message) diff --git a/web/Areas/RAPS/Views/Members/List.cshtml b/web/Areas/RAPS/Views/Members/List.cshtml index 9b03e9f06..98816e24c 100644 --- a/web/Areas/RAPS/Views/Members/List.cshtml +++ b/web/Areas/RAPS/Views/Members/List.cshtml @@ -1,4 +1,4 @@ -@{ +@{ ViewData["Title"] = "Members"; }

Search for a user

@@ -34,19 +34,19 @@ no-results-label="No results found">