fix(onboarding): reload after server rename (#1981)

## Summary
This PR improves the onboarding flow when a user changes the Unraid
server name.

A successful hostname change can interrupt the current browser session
and force the user to refresh before continuing. The app cannot bypass
the browser trust / reload interruption itself, but it can choose when
that interruption happens.

Today, the interruption shows up too late in the flow. Users apply
settings successfully, move forward, and only run into the break when
leaving onboarding for the dashboard. This change moves that
interruption to the correct point in the flow. After a successful
server-name change, the Summary step now advances the wizard to
`NEXT_STEPS`, persists that step state, and then reloads the page. Once
the page is back, onboarding can reopen at the persisted next step
instead of forcing the user back through apply.

## Problem
When onboarding applies a server-name change:

- the current browser session can be interrupted
- the current flow waits until the user exits onboarding to surface that
interruption
- this makes the flow feel broken and can lead to confusing re-entry
behavior after refresh

The app cannot automatically bypass the browser interruption, so the
best UX is to make it happen immediately after the rename and before
final completion.

## What Changed
In `OnboardingSummaryStep.vue`:

- widened the `onComplete` prop to allow an async completion path
- added a one-shot `shouldReloadAfterApplyResult` flag
- detect successful server-name changes
- on results dialog confirmation, await the parent completion callback
first
- after step advancement settles, reload the page

This preserves the intended flow:

1. Apply settings
2. Show success dialog
3. User clicks `OK`
4. Advance to `NEXT_STEPS`
5. Reload the page if the successful apply included a server-name change
6. Onboarding resumes from the persisted next step

## Why This Shape
We intentionally reload only after:

- the server-name change succeeded
- the parent `onComplete()` callback has already advanced the step

That keeps the refresh tied to the actual rename, while avoiding a
regression where users would come back to the Summary step and re-run
apply.

## Testing
Added and updated a focused regression test in
`web/__test__/components/Onboarding/OnboardingSummaryStep.test.ts` that
verifies:

- a successful server rename arms the reload behavior
- the Summary step still waits for the user to confirm the result dialog
- `onComplete()` is invoked before the reload happens
- `window.location.reload()` is called exactly once in the rename case

Validated with:

```bash
pnpm test __test__/components/Onboarding/OnboardingSummaryStep.test.ts
```

## Notes
This PR does not attempt to eliminate the browser interruption itself.
That is outside the control of the web app. It only makes the
interruption happen at the right moment and preserves onboarding
progress across that reload.

Author: Ajit-Mehrotra

web/__test__/components/Onboarding/OnboardingSummaryStep.test.ts

@@ -295,7 +295,7 @@ interface SummaryVm {
   applyResultSeverity: 'success' | 'warning' | 'error';
   handleBootDriveWarningConfirm: () => Promise<void>;
   handleBootDriveWarningCancel: () => void;
-  handleApplyResultConfirm: () => void;
+  handleApplyResultConfirm: () => Promise<void>;
 }
 
 const getSummaryVm = (wrapper: ReturnType<typeof mountComponent>['wrapper']) =>
@@ -332,7 +332,7 @@ const clickButtonByText = async (
     } else if (normalizedTarget === 'cancel') {
       vm.handleBootDriveWarningCancel();
     } else if (normalizedTarget === 'ok') {
-      vm.handleApplyResultConfirm();
+      await vm.handleApplyResultConfirm();
     } else {
       expect(button).toBeTruthy();
     }
@@ -1015,6 +1015,28 @@ describe('OnboardingSummaryStep', () => {
     expect(onComplete).not.toHaveBeenCalled();
   });
 
+  it('advances to next steps before reloading after a successful server rename', async () => {
+    draftStore.serverName = 'Newtower';
+    const reloadSpy = vi.spyOn(window.location, 'reload').mockImplementation(() => undefined);
+    const { wrapper, onComplete } = mountComponent();
+
+    await clickApply(wrapper);
+
+    expect(updateServerIdentityMock).toHaveBeenCalledWith({
+      name: 'Newtower',
+      comment: '',
+      sysModel: undefined,
+    });
+    expect(onComplete).not.toHaveBeenCalled();
+
+    await clickButtonByText(wrapper, 'OK');
+
+    expect(onComplete).toHaveBeenCalledTimes(1);
+    expect(reloadSpy).toHaveBeenCalledTimes(1);
+
+    reloadSpy.mockRestore();
+  });
+
   it('retries final identity update after transient network errors when SSH changed', async () => {
     draftStore.useSsh = true;
     draftStore.serverDescription = 'Primary host';

web/src/components/Onboarding/steps/OnboardingSummaryStep.vue

@@ -1,5 +1,5 @@
 <script lang="ts" setup>
-import { computed, onBeforeUnmount, onMounted, ref } from 'vue';
+import { computed, nextTick, onBeforeUnmount, onMounted, ref } from 'vue';
 import { useI18n } from 'vue-i18n';
 import { storeToRefs } from 'pinia';
 import { useMutation, useQuery } from '@vue/apollo-composable';
@@ -57,7 +57,7 @@ import {
 } from '~/composables/gql/graphql';
 
 export interface Props {
-  onComplete: () => void;
+  onComplete: () => void | Promise<void>;
   onBack?: () => void;
   showBack?: boolean;
 }
@@ -227,6 +227,7 @@ const showBootDriveWarningDialog = ref(false);
 const applyResultTitle = ref('');
 const applyResultMessage = ref('');
 const applyResultSeverity = ref<'success' | 'warning' | 'error'>('success');
+const shouldReloadAfterApplyResult = ref(false);
 const summaryT = (key: string, values?: Record<string, unknown>) =>
   t(`onboarding.summaryStep.${key}`, values ?? {});
 
@@ -579,6 +580,7 @@ const handleComplete = async () => {
   isProcessing.value = true;
   error.value = null;
   logs.value = []; // Clear logs
+  shouldReloadAfterApplyResult.value = false;
 
   addLog(summaryT('logs.startingConfiguration'), 'info');
   draftStore.setInternalBootApplySucceeded(false);
@@ -617,6 +619,7 @@ const handleComplete = async () => {
       ? Boolean(coreSettingsResult.value?.vars?.useSsh || false)
       : TRUSTED_DEFAULT_PROFILE.useSsh;
     const currentSysModel = baselineLoaded ? coreSettingsResult.value?.vars?.sysModel || '' : '';
+    const serverNameChanged = baselineLoaded ? targetCoreSettings.serverName !== currentName : false;
     const shouldApplyPartnerSysModel = Boolean(
       isFreshInstall.value &&
         activationSystemModel.value &&
@@ -657,6 +660,9 @@ const handleComplete = async () => {
             }),
           shouldRetryNetworkMutations
         );
+        if (serverNameChanged) {
+          shouldReloadAfterApplyResult.value = true;
+        }
         addLog(summaryT('logs.serverIdentityUpdated'), 'success');
       } catch (caughtError: unknown) {
         hadNonOptimisticFailures = true;
@@ -1032,9 +1038,17 @@ const handleComplete = async () => {
   }
 };
 
-const handleApplyResultConfirm = () => {
+const handleApplyResultConfirm = async () => {
   showApplyResultDialog.value = false;
-  props.onComplete();
+  await Promise.resolve(props.onComplete());
+
+  if (!shouldReloadAfterApplyResult.value) {
+    return;
+  }
+
+  shouldReloadAfterApplyResult.value = false;
+  await nextTick();
+  window.location.reload();
 };
 
 const handleApplyClick = async () => {