Fix PR #53 review issues: cppcheck errors, missing includes, markup injection, code quality

- Fix initializer list order in DisplayWidget.cpp and EditorWidget.cpp (CI blocker)
- Add missing #include <string> in IObserver.h
- Add missing #pragma once in DisplayWidget.h
- Remove unnecessary Controller.h include in DisplayWidget.h
- Remove debug cout statements and redundant assignment in EditorWidget.cpp
- Escape user text in Pango markup (DisplayWidget.cpp, simple_ap.cpp)
- Fix README.md: correct typos and swap pros/cons content
- Add missing newline at end of all new files

Co-authored-by: urbytes21 <118428350+urbytes21@users.noreply.github.com>

Author: Copilot

cmake/Dependencies.cmake

@@ -22,4 +22,4 @@ FetchContent_MakeAvailable(googletest)
 find_package(PkgConfig REQUIRED)
 
 # Check for gtkmm-4.0 specifically, not just gtk4
-pkg_check_modules(GTKMM REQUIRED gtkmm-4.0)
+pkg_check_modules(GTKMM REQUIRED gtkmm-4.0)

src/ap/CMakeLists.txt

@@ -18,4 +18,4 @@ target_sources(ap
 target_link_libraries(ap PRIVATE gtk4-settings)
 
 add_subdirectory(mvc)
-# add_subdirectory(mvvm)
+# add_subdirectory(mvvm)

src/ap/README.md

@@ -46,11 +46,11 @@ View → Controller → Model
 
 ### 4. Examples
 ### 4.1. simple_ap
-- Cos:
+- Pros:
     - Quick, Simple
-- Pos:
+- Cons:
     - Dependency: e.g. what happen when we delete  Gtk::Label m_labelMonitorA;
     - Scalability: 
     - Reusability:
 
-### 4.2. mvc_ap
+### 4.2. mvc_ap

src/ap/mvc/CMakeLists.txt

@@ -9,4 +9,4 @@ target_sources(mvc_ap
     controller/Controller.cpp
 )
 
-target_link_libraries(mvc_ap PRIVATE gtk4-settings)
+target_link_libraries(mvc_ap PRIVATE gtk4-settings)

src/ap/mvc/IObserver.h

@@ -1,7 +1,8 @@
 #pragma once
+#include <string>
 
 class IObserver {
  public:
   virtual ~IObserver() = default;
   virtual void onDataChanged(const std::string& newData) = 0;
-};
+};

src/ap/mvc/controller/Controller.cpp

@@ -9,4 +9,4 @@ void Controller::updateRequest(const std::string& text) {
   // the Controller updates the Model when receiving new data from the View,
   // which then notifies all Views of the change
   model_->setData(text);
-}
+}

src/ap/mvc/controller/Controller.h

@@ -10,4 +10,4 @@ class Controller {
 
  private:
   std::shared_ptr<SharedData> model_;
-};
+};

src/ap/mvc/model/SharedData.cpp

@@ -20,4 +20,4 @@ void SharedData::addObserver(IObserver* obs) {
 
 std::string SharedData::getData() const {
   return data_;
-}
+}

src/ap/mvc/model/SharedData.h

@@ -18,4 +18,4 @@ class SharedData {
  private:
   std::string data_;
   std::vector<IObserver*> observers_;
-};
+};

src/ap/mvc/mvc_ap.cpp

@@ -71,4 +71,4 @@ ContainerWindow::ContainerWindow()
 int main(int argc, char* argv[]) {
   auto app = Gtk::Application::create("org.gtkmm.example.singlemvc");
   return app->make_window_and_run<ContainerWindow>(argc, argv);
-}
+}