Skip to content

Commit ace8912

Browse files
committed
Merge remote-tracking branch 'origin/bugfix/v10.5.5/issue-in-report-creation' into bugfix/v10.5.5/issue-in-report-creation
2 parents 5784233 + 753099b commit ace8912

11 files changed

Lines changed: 87 additions & 71 deletions

File tree

frontend/src/app/app.component.html

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,16 +110,13 @@
110110
</ngx-spinner>
111111

112112
<app-utm-header-health-warning *appHasAnyAuthority="roles" [hidden]="isInExportRoute()"></app-utm-header-health-warning>
113-
114113
<div class="offline" *ngIf="offline">
115-
<div
116-
class="w-100 p-4 bg-danger-400 d-flex justify-content-center align-items-center">
114+
<div class="w-100 p-4 bg-danger-400 d-flex justify-content-center align-items-center">
117115
<h6 class="font-weight-semibold">Unable to connect with the server</h6>
118116
</div>
119117
</div>
120-
<div class="offline" *ngIf="offline !== null && !offline">
121-
<div
122-
class="w-100 p-4 bg-success-400 d-flex justify-content-center align-items-center">
118+
<div class="offline" *ngIf="online && !hideStatus">
119+
<div class="w-100 p-4 bg-success-400 d-flex justify-content-center align-items-center">
123120
<h6 class="font-weight-semibold">Successfully Established Connection with the Server</h6>
124121
</div>
125122
</div>

frontend/src/app/app.component.ts

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {Component, HostListener, OnInit, Renderer2} from '@angular/core';
22
import {Router} from '@angular/router';
33
import {TranslateService} from '@ngx-translate/core';
4-
import {filter} from 'rxjs/operators';
4+
import {delay, filter, tap} from 'rxjs/operators';
55
import {ApiServiceCheckerService} from './core/auth/api-checker-service';
66
import {MenuBehavior} from './shared/behaviors/menu.behavior';
77
import {ThemeChangeBehavior} from './shared/behaviors/theme-change.behavior';
@@ -20,9 +20,11 @@ export class AppComponent implements OnInit {
2020
roles = [ADMIN_ROLE, USER_ROLE];
2121
menu = false;
2222
private height: string;
23-
offline = null;
23+
offline = false;
24+
online = false;
2425
iframeView = false;
2526
favIcon: HTMLLinkElement;
27+
hideStatus = false;
2628

2729
constructor(
2830
private translate: TranslateService,
@@ -53,6 +55,9 @@ export class AppComponent implements OnInit {
5355
if (this.router.url.includes('iframe')) {
5456
this.iframeView = true;
5557
}
58+
if (this.router.url.includes('url')) {
59+
this.hideStatus = true;
60+
}
5661
});
5762
}
5863

@@ -68,12 +73,18 @@ export class AppComponent implements OnInit {
6873

6974
this.apiServiceCheckerService.isOnlineApi$
7075
.pipe(
71-
filter(isOnline => isOnline))
72-
.subscribe(isOnline => {
73-
if (this.offline) {
74-
this.init();
75-
}
76-
setTimeout(() => this.offline = null, 3000);
76+
filter(isOnline => isOnline),
77+
tap(() => {
78+
if (this.offline) {
79+
this.init();
80+
}
81+
this.online = true;
82+
}),
83+
delay(1000)
84+
)
85+
.subscribe(() => {
86+
this.offline = false;
87+
this.online = false;
7788
});
7889
}
7990

frontend/src/app/dashboard/compliance-export/compliance-export.component.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
</div>
1818
</div>
1919

20+
21+
<div *ngIf="preparingPrint" class="report-loading"></div>
2022
<div class="d-flex justify-content-center align-items-start w-100 m-0 d-print-block">
2123
<div class="compliance-front-page">
2224

@@ -74,7 +76,6 @@ <h5 class="mb-2 w-50">Compliance report</h5>
7476

7577
<div [ngClass]="printFormat?'vis-container-print':'mt-4'" class="w-100">
7678

77-
<app-render-visualization-print [loadingVisualizations]="loadingVisualizations"
78-
(visualizationLoaded)="onVisualizationLoaded()"
79+
<app-render-visualization-print (visualizationLoaded)="onVisualizationLoaded()"
7980
[visualizationRender]="visualizationRender"></app-render-visualization-print>
8081
</div>

frontend/src/app/dashboard/compliance-export/compliance-export.component.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,13 @@ export class ComplianceExportComponent implements OnInit, AfterViewInit {
9393
}
9494

9595
ngOnInit() {
96-
this.spinner.show('buildPrint');
96+
/* this.spinner.show('buildPrint');
9797
window.addEventListener('beforeprint', (event) => {
9898
this.printFormat = true;
9999
});
100100
window.addEventListener('afterprint', (event) => {
101101
this.printFormat = false;
102-
});
102+
});*/
103103
this.activatedRoute.params.subscribe(params => {
104104
this.reportId = params.id;
105105
this.getTemplate();
@@ -204,12 +204,14 @@ export class ComplianceExportComponent implements OnInit, AfterViewInit {
204204
}
205205

206206
onVisualizationLoaded() {
207-
this.setVisFilter().then(() => {
207+
this.preparingPrint = false;
208+
console.log('onVisualizationLoaded');
209+
/*this.setVisFilter().then(() => {
208210
this.spinner.hide('buildPrint').then(() => {
209211
this.preparingPrint = false;
210212
this.print();
211213
});
212-
});
214+
});*/
213215
}
214216

215217
resolveFromDate(date: { from: any, to: any }): string {

frontend/src/app/dashboard/dashboard-export-pdf/dashboard-export-pdf.component.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ <h5 class="mt-5 ">Generated on {{date | date:'short':'UTC'}}</h5>
4040
</div>
4141

4242
<div [ngClass]="printFormat?'vis-container-print':'mt-4'" class="w-100">
43+
<span *ngIf="preparingPrint" class="text-primary">
44+
<i class="spinner icon-spinner2"></i> Loading content, please wait</span>
4345
<div *ngIf="dashboardDescription != ''" class="report-desc-container w-100 d-flex justify-content-center align-items-center flex-column">
4446
<div class="report-description dashboard-info-container d-flex align-items-start w-100">
4547
<p class="font-size-lg mb-3">{{dashboardDescription}}</p>
@@ -69,7 +71,6 @@ <h5 class="mt-5 ">Generated on {{date | date:'short':'UTC'}}</h5>
6971
</div>
7072

7173

72-
<app-render-visualization-print [loadingVisualizations]="loadingVisualizations"
73-
(visualizationLoaded)="onVisualizationLoaded()"
74+
<app-render-visualization-print (visualizationLoaded)="onVisualizationLoaded()"
7475
[visualizationRender]="visualizationRender"></app-render-visualization-print>
7576
</div>

frontend/src/app/dashboard/dashboard-export-pdf/dashboard-export-pdf.component.ts

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,16 +65,15 @@ export class DashboardExportPdfComponent implements OnInit, AfterViewInit {
6565
});
6666
}
6767
});
68-
this.spinner.show('buildPrint');
6968
this.accountService.identity().then(account => {
7069
this.account = account;
7170
});
72-
window.addEventListener('beforeprint', (event) => {
71+
/*window.addEventListener('beforeprint', (event) => {
7372
this.printFormat = true;
7473
});
7574
window.addEventListener('afterprint', (event) => {
7675
this.printFormat = false;
77-
});
76+
});*/
7877
this.activatedRoute.params.subscribe(params => {
7978
this.dashboardId = params.id;
8079
if (this.dashboardId) {
@@ -144,12 +143,8 @@ export class DashboardExportPdfComponent implements OnInit, AfterViewInit {
144143
}
145144

146145
onVisualizationLoaded() {
147-
this.setVisFilter().then(() => {
148-
this.spinner.hide('buildPrint').then(() => {
149-
this.preparingPrint = false;
150-
// this.print();
151-
});
152-
});
146+
this.preparingPrint = false;
147+
console.log('onVisualizationLoaded');
153148
}
154149

155150
getTimeFilterValue() {

frontend/src/app/dashboard/dashboard-overview/dashboard-overview.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export class DashboardOverviewComponent implements OnInit, OnDestroy {
128128
* END
129129
*/
130130

131-
this.getDailyAlert();
131+
// this.getDailyAlert();
132132

133133
/**
134134
* Show activate modules modal on constructor

frontend/src/app/dashboard/shared/render-visualization-print/render-visualization-print.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="container-fluid container-export">
2-
<div *ngIf="visualizationRender&& !loadingVisualizations"
2+
<div *ngIf="visualizationRender"
33
class="d-flex flex-column justify-content-center align-items-center">
44
<div #container
55
*ngFor="let vis of visualizationRender"
@@ -20,7 +20,7 @@
2020
</div>
2121
</div>
2222
</div>
23-
<div *ngIf="loadingVisualizations"
23+
<div *ngIf="!loadingVisualizations"
2424
class="dashboard-loader d-flex justify-content-center align-content-center">
2525
<app-utm-spinner [height]="'110px'" [loading]="loadingVisualizations" [width]="'110px'"
2626
label="Loading dashboard"

frontend/src/app/dashboard/shared/render-visualization-print/render-visualization-print.component.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {ChartTypeEnum} from '../../../shared/enums/chart-type.enum';
99
})
1010
export class RenderVisualizationPrintComponent implements OnInit {
1111
@Input() visualizationRender: UtmDashboardVisualizationType[];
12-
@Input() loadingVisualizations = true;
12+
@Input() loadingVisualizations = false;
1313
@Output() visualizationLoaded = new EventEmitter<boolean>();
1414
runList = 0;
1515
chartTypeEnum = ChartTypeEnum;
@@ -37,8 +37,9 @@ export class RenderVisualizationPrintComponent implements OnInit {
3737
onRun($event: string) {
3838
this.runList += 1;
3939
if (this.runList === this.visualizationRender.length) {
40+
this.loadingVisualizations = true;
4041
console.log('All the visualizations data has loaded, waiting for rendering');
41-
setTimeout(() => this.visualizationLoaded.emit(true), 5000);
42+
setTimeout(() => this.visualizationLoaded.emit(true), 3000);
4243
console.log('All the visualizations now has rendered');
4344
}
4445
}

frontend/src/app/shared/components/auth/login/login.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,13 @@
6262
</div>
6363
<!-- /login form -->
6464
<ng-template #loading>
65-
<app-utm-spinner [loading]="true" label="Loading"></app-utm-spinner>
65+
<app-utm-spinner [loading]="loadingLogin" label="Loading"></app-utm-spinner>
6666
</ng-template>
6767

6868
</div>
6969

7070
<!-- /content area -->
7171
<div *appHasAnyAuthority="roles" class="content d-flex justify-content-center align-items-center h-100 w-100">
72-
<app-utm-spinner [height]="'35px'" [label]="'Loading modules...'" [loading]="true"
72+
<app-utm-spinner [height]="'35px'" [label]="'Loading modules...'" [loading]="!isInternalNavigation"
7373
[width]="'35px'"></app-utm-spinner>
7474
</div>

0 commit comments

Comments
 (0)