This repository was archived by the owner on Feb 16, 2026. It is now read-only.
HSH: Limit the number of non matching variants evaluated against the ban list during lookup#4253
Merged
Merged
Conversation
Member
|
after bugwash discussion:
|
Member
Author
Also added a paragraph in purging.rst about the new |
nigoroll
approved these changes
Jan 20, 2025
Member
Author
|
bugwash: make docs clearer |
Member
Author
Member
|
I was not addressed, but I think the document improvement is very good. |
This will control the number of object variants that we evaluate against the ban list before looking for a vary match. Refs: varnishcache#4236
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of the solution suggested by @bsdphk in #4236 (comment)
It adds a parameter to limit the number of possibly non matching variants that we evaluate against the ban list during a lookup.
Leaving this as a draft until we agree on the parameter name.
Refs: #4236