Move cloud object models to separate crate.

[vorporeal]

Description

Moves the remaining low-level cloud object model definitions out of the app crate so they can be reused outside warp without pulling in app-specific code.

This PR moves the workflow enum and cloud environment model surfaces into the server/client cloud object layer while keeping compatibility re-exports for existing app call sites. This is a preparatory step toward extracting the shared cloud object substrate and model crates in the follow-up PRs.

Note

note from dstern: this honestly should probably just have been merged into a higher PR in the stack (which pulls these back out of cloud_objects and into a cloud_object_models crate with all of the other models), but it's here, so cest la vie

Linked Issue

None.

Testing

• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --tests

No manual app testing; this is a crate-boundary refactor with no intended product behavior changes.

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Co-Authored-By: Oz oz-agent@warp.dev

[vorporeal]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Extract cloud object persistence logic to other crates. #11179 : 2 dependent PRs (#11378 , #11487 )
• Extract CloudObject client and models to separate crates. #11166
• Create cloud_objects crate. #11165
• Move cloud object models to separate crate. #11164 👈 (View in Graphite)
• Move GenericStringModel to warp_server_client. #11117
• Move GenericCloudObject to warp_server_client. #11115
• Move GenericServerObject to warp_server_client. #11114
• Move some types to the warp_server_client crate. #11113
• Delete unused new_from_server_update function. #11112
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves the workflow enum and cloud environment model definitions into warp_server_client::cloud_object::models and re-exports them from the existing app modules to preserve current call sites. The moved models keep the same serde attributes, trait derives, constructors, and display behavior, and no approved spec context was available for additional implementation validation.

Concerns

• No blocking correctness, security, or spec-alignment concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz