Extract cloud object persistence logic to other crates.

[vorporeal]

Description

Pulls cloud-object SQLite persistence out of the warp app crate so Diesel-heavy persistence code can live in smaller, purpose-specific crates while preserving a path toward future model verticalization.

• Adds cloud_object_persistence for shared cloud-object persistence infrastructure, including metadata/permissions helpers, refresh scheduling, guest/link-sharing encoding, callback-based upsert/delete primitives, and generic string object table access.
• Moves notebook, workflow, folder, and generic-string model persistence adapters under their corresponding cloud_object_models modules so model-specific persistence can move with those models later.
• Removes warp_server_client::persistence as a compatibility home and updates imports to use cloud_object_persistence directly.
• Keeps app/src/persistence/sqlite.rs focused on app persistence orchestration and app-local object action conversion.
• Adds crate-level docs for the cloud-object crates to document their intended scopes and dependency boundaries.

Testing

• cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_persistence
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_models --tests
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --tests
• cargo nextest run --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_persistence
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_objects -p cloud_object_models -p cloud_object_persistence
• cargo check -p warp

Not manually tested; this is an internal persistence refactor with no expected user-visible behavior changes.

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Co-Authored-By: Oz oz-agent@warp.dev

[vorporeal]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Extract cloud object persistence logic to other crates. #11179 : 2 dependent PRs (#11378 , #11487 ) 👈 (View in Graphite)
• Extract CloudObject client and models to separate crates. #11166
• Create cloud_objects crate. #11165
• Move cloud object models to separate crate. #11164
• Move GenericStringModel to warp_server_client. #11117
• Move GenericCloudObject to warp_server_client. #11115
• Move GenericServerObject to warp_server_client. #11114
• Move some types to the warp_server_client crate. #11113
• Delete unused new_from_server_update function. #11112
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR extracts cloud-object SQLite persistence into a new cloud_object_persistence crate and moves model-specific persistence adapters into cloud_object_models, while updating the app and server-client crates to use the new boundaries.

Concerns

• No blocking correctness, security, or spec-alignment concerns found in the reviewed diff.
• No approved spec context was available for comparison.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz