runtime: fix nil and closed channel select semantics#1894
Draft
cpunion wants to merge 2 commits into
Draft
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
Chan/select update pushed in Scope kept to chan/select runtime semantics:
Left out of this PR: Local validation:
CI is queued/running on the new head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/gochannel/select coverage and remove only the now-fixedchan/select3.goGOROOT xfails.Tests
go test ./test/goroot -run TestGoRootRunCases/chan/select3.go -count=1 -args -goroot "$(go env GOROOT)" -dirs chan -case '^chan/select3\.go$' -xfail /tmp/llgo-no-xfail.yaml -run-timeout 20s -build-timeout 3mfailed with llgo nil pointer panic inmain$1.go test ./test/go -run 'Test(NilChannel|ClosedChannel)' -count=1go test ./test/go -count=1go run ./cmd/llgo test -count=1 ./test/go/channel_select_semantics_test.gogo test ./cl -run TestRunFromTestgoSelectAllowsKnownInterleavings -count=1go test ./test/goroot -run TestGoRootRunCases/chan/select3.go -count=1 -args -goroot "$(go env GOROOT)" -dirs chan -case '^chan/select3\.go$' -xfail /tmp/llgo-no-xfail.yaml -run-timeout 20s -build-timeout 3mgo test ./test/goroot -run TestGoRootRunCases/chan/select3.go -count=1 -args -goroot "$(go env GOROOT)" -dirs chan -case '^chan/select3\.go$' -run-timeout 20s -build-timeout 3mchan/select2.gostill fails with xfail disabled, so its xfail remains.CI
xgo-dev/llgo. If manual GOROOTworkflow_dispatchcannot resolve fork refs, that remains a workflow blocker rather than a reason to push to upstream.