Skip to content

Publish implementation work surface#394

Merged
SoundBlaster merged 2 commits into
mainfrom
codex/publish-implementation-work-index
May 16, 2026
Merged

Publish implementation work surface#394
SoundBlaster merged 2 commits into
mainfrom
codex/publish-implementation-work-index

Conversation

@SoundBlaster
Copy link
Copy Markdown
Member

Summary

  • What changed?
  • Publish bundle generation now treats runs/implementation_work_index.json as a required public artifact for SpecSpace.
  • Link related issue/task (if any): SpecSpace WORK datasource readiness.

Motivation

  • Why is this change needed?
  • SpecSpace expects the Implementation Work surface to be present in the static artifact bundle, but make publish-bundle only refreshed common viewer surfaces before packaging.
  • What problem, gap, or user need does it address?
  • After deploy, artifact_manifest.json should list runs/implementation_work_index.json so SpecSpace can mark WORK as available.

Goals

  • What should this PR achieve?
  • Generate runs/implementation_work_index.json during publish bundle refresh.
  • Include runs/implementation_work_index.json in artifact_manifest.json and checksums.sha256.
  • Fail the bundle safety gate if the implementation-work surface is missing.
  • What is intentionally out of scope?
  • No changes to canonical specs, raw tracked runs/, or SpecSpace runtime code.

Changes

  • Added implementation_work_index.json to required static run surfaces.
  • Changed publish refresh to run both make viewer-surfaces and make implementation-work before collecting artifacts.
  • Added regression coverage for manifest/checksum inclusion, required-surface failure, and refresh target order.
  • Updated static artifact publish docs.

Validation

  • Tests added/updated for changed behavior
  • Local checks passed

Commands run:

python3 -m pytest -q tests/test_static_artifact_bundle.py
make implementation-work
make publish-bundle
python3 - <<'PY'
import json
from pathlib import Path
m=json.loads(Path('dist/specgraph-public/artifact_manifest.json').read_text())
print('required implementation_work_index:', m['required_surfaces'].get('implementation_work_index.json'))
print('manifest file entry:', any(f['path']=='runs/implementation_work_index.json' for f in m['files']))
print('checksum entry:', 'runs/implementation_work_index.json' in Path('dist/specgraph-public/checksums.sha256').read_text())
print('published file:', Path('dist/specgraph-public/runs/implementation_work_index.json').is_file())
PY

Results:

  • tests/test_static_artifact_bundle.py: 9 passed.
  • make implementation-work: wrote implementation_work_index with entry_count: 0.
  • make publish-bundle: passed safety gate with no warnings.
  • Bundle verification: required surface, manifest entry, checksum entry, and published file all True.

Risks / Notes

  • Backward compatibility impact: low; this only adds one required public surface to the static artifact bundle.
  • Migration/config changes required: none beyond redeploying the static artifact workflow after merge.
  • Known limitations: runs/implementation_work_index.json is generated from the current implementation delta snapshot; when there is no implementation delta, the artifact is valid with entry_count: 0.

Checklist

  • PR title clearly describes the change
  • Scope is focused and minimal
  • Documentation updated (or N/A)
  • No secrets or sensitive data added

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2cf0969df8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/build_static_artifact_bundle.py
@SoundBlaster
Copy link
Copy Markdown
Member Author

Addressed review thread #394 (comment)

Fixed. publish-bundle now refreshes the implementation delta snapshot before building the implementation work index: viewer-surfaces -> implementation-delta -> implementation-work. Added the make implementation-delta shortcut with an explicit root active_subtree publish intent, updated docs, and adjusted regression coverage. Verified locally with python3 -m pytest -q tests/test_static_artifact_bundle.py and make publish-bundle; the bundle now includes both runs/implementation_delta_snapshot.json and runs/implementation_work_index.json.

@SoundBlaster SoundBlaster merged commit be5a199 into main May 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant