Fix: enforce recursive object and Slice typing by 0xLeif · Pull Request #129 · 0xLeif/aps-cli

0xLeif · 2026-07-27T14:35:57Z

Summary

preserve recursive structural JSON and document JSON-standard integral-number canonicalization
validate typed initials, open object shapes, and nonfinite recursive descendants before mutation or output
reject present undecodable StoredState objects as corrupt_state while preserving absent-value initials
require every Slice to reference an explicitly declared, type-compatible FileState object field
advertise every recursive JSON kind in schema contract version 6
add repeatable key add --field NAME=TYPE and userSchema.keyCount
update README, dynamic-schema design, canonical specs, and Unix/PowerShell smoke coverage

Test Plan

fledge lanes run verify
252 serial Swift tests
252 parallel Swift tests
expanded Unix smoke
PowerShell parser validation and targeted cross-platform contract sequence
CHG-0051 and CHG-0056 accepted with exact evidence
fledge spec check --strict: 2 specs, 0 errors, 0 warnings
hosted CI, Linux smoke, Windows smoke, and Trust on final SHA

Closes #114

cursor · 2026-07-28T19:29:32Z

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65b8b5c018

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5ccc63c84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 058730a6bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24aeb9192d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 495b377cfb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01128bd888

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd2b2ef5d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28a9781e05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 256bd9a360

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Archive CHG-0051 and CHG-0056 through CHG-0061 after merged PR #129.

0xLeif mentioned this pull request Jul 27, 2026

Enforce dynamic object and Slice typing and restore schema metadata #114

Closed

Base automatically changed from leif/issue-118-secret-hardening to main July 28, 2026 18:48

0xLeif added 5 commits July 28, 2026 13:07

fix(schema): enforce recursive object and Slice typing

116dc00

fix(tests): make actor-isolated tests Linux discoverable

5576147

chore(specsync): refresh CHG-0051 verification evidence

c26713a

chore(specsync): accept CHG-0051 after hosted verification

91426eb

update(specs): refresh CHG-0051 on final base

65b8b5c

0xLeif force-pushed the leif/issue-114-dynamic-object-slice-typing branch from 55d8d77 to 65b8b5c Compare July 28, 2026 19:29

0xLeif marked this pull request as ready for review July 28, 2026 19:29

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread Sources/aps/UserSchema.swift Outdated

Comment thread Sources/aps/DynamicKeyStorage.swift

Comment thread Sources/aps/Schema.swift

Comment thread Sources/aps/UserSchema.swift

0xLeif added 2 commits July 28, 2026 13:59

fix(schema): close final recursive value review gaps

5b63698

Fix: make StoredState corruption tests async

c5ccc63

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread Sources/aps/DynamicKeyStorage.swift

Comment thread Sources/aps/UserSchema.swift Outdated

Comment thread Sources/aps/UserSchema.swift

Comment thread Sources/aps/UserSchema.swift

Comment thread Sources/aps/UserSchema.swift Outdated

Update: refresh SpecSync evidence after Linux fix

058730a

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread Sources/aps/DynamicKeyStorage.swift Outdated

Comment thread Sources/aps/DynamicKeyStorage.swift

Fix: close remaining recursive validation gaps

24aeb91

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread Sources/aps/UserSchema.swift Outdated

Fix: import CoreFoundation for Linux

495b377

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread Sources/aps/DynamicKeyStorage.swift

0xLeif added 2 commits July 28, 2026 15:37

Fix: preserve NSNumber kind checks on Windows

b9b9977

Fix: close final recursive validation gaps

01128bd

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread Sources/aps/UserSchema.swift Outdated

Fix: reject underflowing recursive JSON numbers

fd2b2ef

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread Sources/aps/UserSchema.swift

Fix: preserve recursive decimal values exactly

28a9781

chatgpt-codex-connector Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread Sources/aps/UserSchema.swift Outdated

Fix: retain finite Double exponent range

256bd9a

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread Sources/aps/UserSchema.swift

0xLeif merged commit 756fb69 into main Jul 29, 2026
5 checks passed

0xLeif deleted the leif/issue-114-dynamic-object-slice-typing branch July 29, 2026 00:08

0xLeif mentioned this pull request Jul 29, 2026

Update: archive PR 129 SpecSync changes #132

Merged

2 tasks

0xLeif added a commit that referenced this pull request Jul 29, 2026

Update: archive PR 129 SpecSync changes (#132)

df2e791

Archive CHG-0051 and CHG-0056 through CHG-0061 after merged PR #129.

Conversation

0xLeif commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

cursor Bot commented Jul 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

0xLeif commented Jul 27, 2026 •

edited

Loading