Skip to content

refactor(store): add sql conversions for db binary types#2126

Open
Mr-kay-cloud2 wants to merge 3 commits into
0xMiden:nextfrom
Mr-kay-cloud2:fix/sql-conv-coverage
Open

refactor(store): add sql conversions for db binary types#2126
Mr-kay-cloud2 wants to merge 3 commits into
0xMiden:nextfrom
Mr-kay-cloud2:fix/sql-conv-coverage

Conversation

@Mr-kay-cloud2
Copy link
Copy Markdown
Contributor

Summary

  • Adds SqlTypeConvert implementations for common binary database types used by the store.
  • Centralizes byte serialization/deserialization for account, note, transaction, and storage map primitives.
  • Adds roundtrip and malformed-byte tests for the new conversion path.

Closes #1477

Testing

  • rustfmt +nightly --edition 2024 crates/store/src/db/models/conv.rs
  • cargo test -p miden-node-store db::models::conv::tests --lib could not run locally on Windows because the miden-agglayer dependency checkout fails on an invalid : path in a submodule file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit and add missing conversions to conv.rs

1 participant