refactor(block-producer): yank gRPC service#2140
Open
Mirko-von-Leipzig wants to merge 1 commit into
Open
Conversation
Mirko-von-Leipzig
added
rpc
This was referenced May 26, 2026
| block_budget: BlockBudget { batches: self.max_batches_per_block }, | ||
| tx_capacity: self.mempool_tx_capacity, | ||
| ..Default::default() | ||
| let api_config = BlockProducerApiConfig { |
Collaborator
There was a problem hiding this comment.
Should we create a constructor for BlockProducerApiConfig?
Collaborator
Author
There was a problem hiding this comment.
Probably, but I'll defer that to clean up afterwards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the block producer gRPC service. Transaction and batch submissions are instead injected directly in the RPC handlers.
Ideally this would be the
SharedMempoolbut I've elected to make that change in a follow-up PR instead. This would require moving a shared store instance into the RPC layer, and the block and batch builders, which I deemed overly noisy.Stacks on #2139, part of #1961.