feat: gate RPC network tx submission behind internal auth header#2141
Open
kkovaacs wants to merge 6 commits into
Open
feat: gate RPC network tx submission behind internal auth header#2141kkovaacs wants to merge 6 commits into
kkovaacs wants to merge 6 commits into
Conversation
Adds optional internal auth-header support to the shared gRPC client builder, enforces that header in RPC for network-account deployment submissions, and wires `ntx-builder` to send it when configured. Covers single-tx and batch submission paths, validates operator-supplied auth config cleanly at startup, and adds the future node CLI surface for RPC network-tx auth settings.
kkovaacs
force-pushed
the
krisztian/allow-network-transactions
branch
from
58f2f59 to
1257284
Compare
Mirko-von-Leipzig
approved these changes
May 26, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
LGTM modulo removing the header name config
| AsciiMetadataValue::from_str(value) | ||
| .with_context(|| format!("invalid RPC auth header value for `{name}`"))?; | ||
| fn validate_auth_header_value(value: &str) -> anyhow::Result<()> { | ||
| AsciiMetadataValue::from_str(value).with_context(|| { |
Collaborator
There was a problem hiding this comment.
You may be able to embed this directly into the clap type since it impls from_str
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional internal auth-header support to the shared gRPC client builder, enforces that header in RPC for network-account deployment submissions, and wires
ntx-builderto send it when configured. The default name of the header isx-miden-network-tx-auth.Covers single-tx and batch submission paths, validates operator-supplied auth config cleanly at startup, and adds the future node CLI surface for RPC network-tx auth settings.
Adds the following CLI options to
miden-node fullandmiden-nodesequencer:And
miden-ntx-buildergets added the following new CLI options:Closes #2131