chore: re-add execution of network transactions and add expiration#2148
Open
SantiagoPittella wants to merge 5 commits into
Open
chore: re-add execution of network transactions and add expiration#2148SantiagoPittella wants to merge 5 commits into
SantiagoPittella wants to merge 5 commits into
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-ntx-builder-block-sub-phase-3
branch
from
8b4366b to
b446bbd
Compare
Mirko-von-Leipzig
approved these changes
May 29, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Some suggestions, but looks good otherwise.
Comment on lines
+27
to
+30
| -- TransactionId (32 bytes) of the latest transaction that updated this account in a committed | ||
| -- block. NULL until the first transaction lands. Actors compare their own submitted tx id | ||
| -- against this to confirm landing without an RPC roundtrip. | ||
| last_tx_id BLOB |
Collaborator
There was a problem hiding this comment.
Could be NOT NULL since this will be filled in as the blocks are applied during sync?
Comment on lines
+67
to
+71
| pub fn set_account_last_tx( | ||
| conn: &mut SqliteConnection, | ||
| account_id: AccountId, | ||
| tx_id: TransactionId, | ||
| ) -> Result<(), DatabaseError> { |
Collaborator
There was a problem hiding this comment.
I think this could be folded into upsert_account since we should always be able to determine the last tx in a block that updated this?
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third and final PR of the ntx-builder block-subscription refactor (follows #2120 and #2144). This PR reconnects the execution path so the ntx-builder actually builds and submits network transactions again.
After catch-up, an account actor with pending notes selects a candidate, executes/proves/submits it, then enters a
WaitForBlockstate and detects landing purely from local state. If the transaction doesn't land withintx_expiration_deltablocks, the actor resubmits.Submitted transactions also carry an on-chain expiration: a pre-compiled transaction script (
update_expiration_block_delta) is injected viaTransactionArgs, so a stale tx is rejected by the chain rather than landing late.