feat: implement Clone for TransactionContextBuilder#2979
Open
PhilippGackstatter wants to merge 2 commits into
Open
feat: implement Clone for TransactionContextBuilder#2979PhilippGackstatter wants to merge 2 commits into
Clone for TransactionContextBuilder#2979PhilippGackstatter wants to merge 2 commits into
Conversation
PhilippGackstatter
added
no changelog
PhilippGackstatter
force-pushed
the
pgackst-clone-for-tx-context-builder
branch
from
3f5b81b to
c8e701f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
CloneforTransactionContextBuilderso we can simplify multisig test code that rebuilds transaction contexts twice: once to get the tx summary, once to execute.Also adds a helper for unwrapping a
TransactionExecutorError::Unauthorizedvariant.Motivated by reducing line count in general but in particular for #2973.