fix: metadata field does not handle null values (#1538)#1795
Open
tao501 wants to merge 1 commit into
Open
Conversation
tao501
force-pushed
the
fix/metadata-null-handling
branch
from
996237c to
b33119c
Compare
The `metadata` field in `AdditionalParameters` (OpenAI Responses API) was typed as `Map<String, Value>` without null handling. When OpenAI-compatible providers return `metadata: null`, deserialization fails. - Changed `metadata` type to `Option<Map<String, Value>>` in responses_api/mod.rs - Updated `.metadata.clear()` to `.metadata = None` in chatgpt/mod.rs - Added 7 test cases covering null/empty/missing/object metadata deserialization
tao501
force-pushed
the
fix/metadata-null-handling
branch
from
b33119c to
b135b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1538
The
metadatafield inAdditionalParameterswas typed asMap<String, Value>without null handling. When OpenAI-compatible providers (e.g., vLLM) returnmetadata: nullin the response, deserialization fails.Changes:
metadatatype toOption<Map<String, Value>>in responses_api/mod.rs.metadata.clear()to.metadata = Nonein chatgpt/mod.rsAll existing tests pass (74 openai + 13 chatgpt).