feat: support certificate synchronization#13153
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 120508224c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Container: installed.ContainerName, | ||
| ServiceName: strings.ToLower(installed.ServiceName), | ||
| ResourceKeys: resourceKeys, | ||
| Env: envMap, |
There was a problem hiding this comment.
When /apps/installed/search builds its normal listing through handleInstalled, this now serializes installed.Env for every returned app. That field is populated from install parameters and is used elsewhere for secrets such as PANEL_DB_ROOT_PASSWORD and REPLICATION_PASSWORD, so app/website listing calls that previously returned metadata now bulk-expose all installed-app environment secrets; keep this data behind the per-install/detail or sync-specific path instead of adding it to the generic DTO.
Useful? React with 👍 / 👎.
| "/xpack/node": {}, | ||
| "/xpack/simple-node": {}, | ||
| "/xpack/sync": {}, | ||
| "/xpack/sync/file": {}, |
There was a problem hiding this comment.
The menu data still points the Resource Sync entry at /xpack/sync (core/init/migration/helper/menu.go and the migration do the same), but this change removes the parent path from WebUrlMap; core/utils/security.IsFrontendPath only serves SPA routes present in that map or DynamicRoutes. In deployments where a user opens the menu URL directly or refreshes on /xpack/sync, the backend will no longer serve the frontend route, so add /xpack/sync back alongside the child routes.
Useful? React with 👍 / 👎.
1 participant
No description provided.