Skip to content

fix: complete operation logs#13155

Merged
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@fix_operation_log
Jun 30, 2026
Merged

fix: complete operation logs#13155
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@fix_operation_log

Conversation

@ssongliu

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57e68b85cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 2265 to +2266
"/core/xpack/sync/app": {
"bodyKeys": [
"sourceNode",
"targetNodes",
"appInstallID"
],
"bodyKeys": [],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add the log entry for the install endpoint

The operation log lookup is keyed by the exact request path, but the current UI posts node app installs from frontend/src/api/modules/app.ts:144-145 to /core/xpack/sync/app/install. This metadata is attached to /core/xpack/sync/app, so those install requests never match an x-log entry and still won't produce an audit log; please add the entry under the /install path or register a matching route.

Useful? React with 👍 / 👎.

@wanghe-fit2cloud wanghe-fit2cloud merged commit 2cd31a4 into dev-v2 Jun 30, 2026
3 checks passed
@wanghe-fit2cloud wanghe-fit2cloud deleted the pr@dev-v2@fix_operation_log branch June 30, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants