Skip to content

fix: same ref name #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Mar 26, 2026
+5 −1
Merged

fix: same ref name #4956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ui/src/workflow/nodes/parameter-extraction-node/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
</div>
</template>
<NodeCascader
ref="nodeCascaderRef"
ref="inputVariableCascaderRef"
:nodeModel="nodeModel"
class="w-full"
:placeholder="$t('workflow.variable.placeholder')"
Expand Down Expand Up @@ -220,10 +220,14 @@ const model_change = (model_id?: string) => {

const VariableSplittingRef = ref()
const nodeCascaderRef = ref()
const inputVariableCascaderRef = ref()

const validate = async () => {
return Promise.all([
nodeCascaderRef.value ? nodeCascaderRef.value.validate() : Promise.resolve(''),
inputVariableCascaderRef.value
? inputVariableCascaderRef.value.validate()
: Promise.resolve(''),
VariableSplittingRef.value.validate(),
]).catch((err: any) => {
return Promise.reject({ node: props.nodeModel, errMessage: err })
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code provided is mostly correct but has a few minor improvements that can be made:

  1. Consistent Naming Conventions: The naming convention for inputVariableCascaderRef might not match the actual component if 'inputField' were intended to reference something different.

  2. Validation Logic Duplication: Both nodeCascaderRef and inputVariableCascaderRef have identical validation logic in their promises without using an abstracted method like validateChild. Consider extracting this logic into its own function and calling it from both places to avoid repetition.

  3. Documentation Comments: It would help readability to add JSDoc comments describing what each part of the code does, especially with complex components or functions.

Here's the updated and improved version of the code:

// Import necessary library imports here

/**
 * Component responsible for variable splitting
 */
const VariableSplittingContent = defineComponent({
  setup(props) {
    // ... previous variables ...

    /**
     * Refers to the cascader component
     */
    const nodeCascaderRef = ref<NodeCascader>()

    /**
     * Refers to the second cascader (if needed)
     */
    const inputVariableCascaderRef = ref<NodeCascader>()

    const validate = async () => {
      return Promise.all([
        nodeCascaderRef.value ? await validateChild(nodeCascaderRef.value) : Promise.resolve(''),
+        inputVariableCascaderRef.value
          ? await validateChild(inputVariableCascaderRef.value)
          : Promise.resolve('')
      ])
        .catch((err: any) => {
          throw { node: props.nodeModel, errMessage: err }
        });
    }

    // other methods...

    return (
      <div>
        {/* ... */}
      </div>
    )
  },
})

function validateChild(componentInstance: NodeCascader) {
  if (componentInstance && typeof componentInstance.validate === 'function') {
    return componentInstance.validate();
  } else {
    console.error(`${componentInstance?.constructor.name} needs to implement \`validate\` method.`);
    return '';
  }
}

These changes aim to improve code maintainability and readability while fixing a redundant section and ensuring consistent use throughout the component.

Expand Down
Loading