[chore] streamline logging and terminal setup#23
Merged
Conversation
Build the console and no-op loggers directly with zap instead of a thin wrapper, enable Windows ANSI handling via golang.org/x/sys/windows (already in the dependency tree), and use the standard library for the blank-string and OS checks plus a small inline colorizer for the version banner. No change to CLI behaviour; go.mod is tidied accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine maintenance of the logging and terminal-init plumbing:
zap(the console logger writes to stderr, keeping diagnostics off stdout).golang.org/x/sys/windows(already in the dependency tree).No change to CLI behaviour;
go.mod/go.sumare tidied accordingly. Full-raceand the Dockergolang:1.25floor are green; host + Windows cross-compile both build.