Skip to content

Refactor/#441 온보딩,로그인 시 isOnboardingCompleted -> isRegistered로 변경 #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
y-eonee merged 1 commit into from
May 19, 2026
Merged

Refactor/#441 온보딩,로그인 시 isOnboardingCompleted -> isRegistered로 변경 #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ByeBoo-iOS/ByeBoo-iOS/Data/Persistence/UserDefaultsKey.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import Foundation
enum UserDefaultsKey: String, CaseIterable {
case userName
case userID
case isOnboardingCompleted
case isHelperShown
case isRegistered
case loginPlatform
Expand Down
8 changes: 4 additions & 4 deletions ByeBoo-iOS/ByeBoo-iOS/Data/Repository/AuthRepository.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,12 @@ struct DefaultAuthRepository: AuthInterface {
}

func autoLogin() async throws -> Bool {
let isOnboardingCompleted: Bool = userDefaultsService.load(key: .isOnboardingCompleted) ?? false
ByeBooLogger.debug("온보딩 여부 \(isOnboardingCompleted)")
let isRegistered: Bool = userDefaultsService.load(key: .isRegistered) ?? false
ByeBooLogger.debug("온보딩 여부 \(isRegistered)")

if !keychainService.load(key: .accessToken).isEmpty
&& !keychainService.load(key: .refreshToken).isEmpty
&& isOnboardingCompleted
&& isRegistered
{
ByeBooLogger.debug("정보 있음")
try await tokenService.reissue()
Expand Down Expand Up @@ -136,7 +136,7 @@ struct DefaultAuthRepository: AuthInterface {
}

clearKeychain()
removeUserInfo(excludedKeys: [.isOnboardingCompleted, .isHelperShown, .hasEnterMyPage])
removeUserInfo(excludedKeys: [.isRegistered, .isHelperShown, .hasEnterMyPage])

return true
}
Expand Down
2 changes: 1 addition & 1 deletion ByeBoo-iOS/ByeBoo-iOS/Data/Repository/UsersRepository.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ struct DefaultUsersRepository: UsersInterface {
)
let _ = userDefaultsService.save(result.id, key: .userID)
let _ = userDefaultsService.save(result.name, key: .userName)
let _ = userDefaultsService.save(true, key: .isOnboardingCompleted)
let _ = userDefaultsService.save(true, key: .isRegistered)
let _ = userDefaultsService.save(false, key: .hasEnterMyPage)
let _ = userDefaultsService.save(false, key: .alarmEnabled)

Expand Down
4 changes: 2 additions & 2 deletions ByeBoo-iOS/ByeBooTests/Feature/Login/AuthTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ struct AuthTests {
private let networkService = MockNetworkService(userAPI: MockUserAPI(isAvailable: true))

@Test("🏁 isOnboardingCompleted가 true일 때 ✅ 자동로그인 success")
func isOnboardingCompleted_true__autoLogin_success() async throws {
func isRegistered_true__autoLogin_success() async throws {
// Given
let authRepository = MockAuthRepository(
network: networkService,
userDefaultsService: userDefaultsService,
keychainService: keychainService
)
let _ = userDefaultsService.save(true, key: .isOnboardingCompleted)
let _ = userDefaultsService.save(true, key: .isRegistered)
let autoLoginUseCase = DefaultAutoLoginUseCase(repository: authRepository)

// When
Expand Down
Loading