Make the synced repository configurable#103
Merged
Merged
Conversation
The reusable `submodules-sync` workflow assumed its `dev-tools` submodule is a direct submodule of the repository whose submodules should be synced, and always acted on the repo one level up (`cd "$(git rev-parse --show-toplevel)/.."`). That breaks when `dev-tools` is nested more than one level deep — e.g. when a repository vendors another repository (which itself carries `dev-tools`) as a submodule. In that case the workflow enumerates and syncs the *inner* repository's submodules instead of the caller's. Add an optional `submodule_sync_root` input, piped through to `per-submodule-build-matrix.sh` as `SUBMODULE_SYNC_ROOT`, naming the repository directory to act on relative to the checkout root. When it is unset the workflow keeps its previous behavior, so existing callers are unaffected; a caller whose `dev-tools` is nested can pass e.g. "." to sync its own top-level submodules.
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
rjhuijsman
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reusable
submodules-syncworkflow assumed itsdev-toolssubmodule is a direct submodule of the repository whose submodules should be synced, and always acted on the repo one level up (cd "$(git rev-parse --show-toplevel)/..").That breaks when
dev-toolsis nested more than one level deep — e.g. when a repository vendors another repository (which itself carriesdev-tools) as a submodule. In that case the workflow enumerates and syncs the inner repository's submodules instead of the caller's.Add an optional
submodule_sync_rootinput, piped through toper-submodule-build-matrix.shasSUBMODULE_SYNC_ROOT, naming the repository directory to act on relative to the checkout root. When it is unset the workflow keeps its previous behavior, so existing callers are unaffected; a caller whosedev-toolsis nested can pass e.g. "." to sync its own top-level submodules.